refactor: phpdoc for Config\Filters::$globals#9652
Merged
michalsn merged 2 commits intocodeigniter4:developfrom Aug 1, 2025
Merged
refactor: phpdoc for Config\Filters::$globals#9652michalsn merged 2 commits intocodeigniter4:developfrom
Config\Filters::$globals#9652michalsn merged 2 commits intocodeigniter4:developfrom
Conversation
neznaika0
approved these changes
Jul 31, 2025
Contributor
neznaika0
left a comment
neznaika0
left a comment
There was a problem hiding this comment.
array<int|string, ...> Is INT needed for an empty array? Otherwise, it is optional - it is unlikely that it will ever be a list.
Member
Author
|
I don't feel strong with these rules at all, but PHPStan infers 'after' => [
'foo' => ['except' => ['api/*']],
'bar', // <- this is an indexed element with key 0
],So in this case Maybe there is a better way to solve this. |
Contributor
|
Okay, don't strain yourself. It is for filters that string keys should be used, but not |
paulbalandan
reviewed
Aug 1, 2025
Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates PHPDoc for
Config\Filters::$globalsFixes #9651
Checklist: