fix: check if defined WRITEPATH exists#9317
Merged
michalsn merged 4 commits intocodeigniter4:developfrom Dec 12, 2024
Merged
Conversation
neznaika0
reviewed
Dec 11, 2024
Contributor
neznaika0
left a comment
neznaika0
left a comment
There was a problem hiding this comment.
Do I need to use DS? Windows is not supported
datamweb
reviewed
Dec 11, 2024
Member
Author
|
@neznaika0 |
Contributor
|
I know that the paths are right for the system. But for tests and other manipulations, this is a problem - different slashes |
kenjis
added
the
bug
Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
kenjis
approved these changes
Dec 12, 2024
paulbalandan
approved these changes
Dec 12, 2024
Member
Author
|
Thanks everyone! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check that
WRITEPATHis defined correctly.Fixes: #9309
Checklist: