In Websocket proxy, don't forward User-Agent. Fixes aspnet#1469.

SteveSandersonMS · SteveSandersonMS · commit bf5f40b1edc1 · 2018-02-08T11:40:14.000Z
diff --git a/src/Microsoft.AspNetCore.SpaServices.Extensions/Proxying/SpaProxy.cs b/src/Microsoft.AspNetCore.SpaServices.Extensions/Proxying/SpaProxy.cs
@@ -22,7 +22,9 @@ internal static class SpaProxy
         private const int DefaultWebSocketBufferSize = 4096;
         private const int StreamCopyBufferSize = 81920;
 
-        private static readonly string[] NotForwardedWebSocketHeaders = new[] { "Connection", "Host", "Upgrade", "Sec-WebSocket-Key", "Sec-WebSocket-Version" };
+        // Don't forward User-Agent because of https://github.com/aspnet/JavaScriptServices/issues/1469
+        // Others just aren't applicable in proxy scenarios
+        private static readonly string[] NotForwardedWebSocketHeaders = new[] { "Connection", "Host", "User-Agent", "Upgrade", "Sec-WebSocket-Key", "Sec-WebSocket-Version" };
 
         public static HttpClient CreateHttpClientForProxy(TimeSpan requestTimeout)
         {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,9 @@ internal static class SpaProxy`
`22`	`22`	`private const int DefaultWebSocketBufferSize = 4096;`
`23`	`23`	`private const int StreamCopyBufferSize = 81920;`
`24`	`24`
`25`		`- private static readonly string[] NotForwardedWebSocketHeaders = new[] { "Connection", "Host", "Upgrade", "Sec-WebSocket-Key", "Sec-WebSocket-Version" };`
	`25`	`+ // Don't forward User-Agent because of https://github.com/aspnet/JavaScriptServices/issues/1469`
	`26`	`+ // Others just aren't applicable in proxy scenarios`
	`27`	`+ private static readonly string[] NotForwardedWebSocketHeaders = new[] { "Connection", "Host", "User-Agent", "Upgrade", "Sec-WebSocket-Key", "Sec-WebSocket-Version" };`
`26`	`28`
`27`	`29`	`public static HttpClient CreateHttpClientForProxy(TimeSpan requestTimeout)`
`28`	`30`	`{`