Skip to content

fix: move yarn to bun for Node-Vitest #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pranavtechie merged 1 commit into from
Jan 16, 2024
Merged

fix: move yarn to bun for Node-Vitest #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/technologies/node.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ set -e 1

# Install vitest and testing util
cd /home/damner/code
yarn add vitest@0.32.2 jsdom@22.1.0 @testing-library/jest-dom@5.16.5 --dev
bun add vitest@0.32.2 jsdom@22.1.0 @testing-library/jest-dom@5.16.5 --dev
mkdir -p /home/damner/code/.labtests

# Move test file
Expand Down Expand Up @@ -148,11 +148,11 @@ cat > /home/damner/code/.labtests/package.json << EOF
EOF

# run test
(yarn vitest run --config=/home/damner/code/.labtests/config.js --threads=false --reporter=json --outputFile=/home/damner/code/.labtests/payload.json || true) | tee /home/damner/code/.labtests/evaluationscript.log
(bun vitest run --config=/home/damner/code/.labtests/config.js --threads=false --reporter=json --outputFile=/home/damner/code/.labtests/payload.json || true) | tee /home/damner/code/.labtests/evaluationscript.log

# Write results to UNIT_TEST_OUTPUT_FILE to communicate to frontend
cd /home/damner/code/.labtests
node process.js
bun process.js
Copy link
Copy Markdown
Member

@mehulmpt mehulmpt Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not change the runtime to bun just yet.

Copy link
Copy Markdown
Contributor Author

@Pranavtechie Pranavtechie Jan 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gotten a CJS/ESM error. So changed this to bun as well and fixed the issue

```

Let's understand what the above evaluation script is doing:
Expand Down