This repository was archived by the owner on May 21, 2025. It is now read-only.
Fixed gcov not being found in certain instances. #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=====================================
Coverage 88% 88%
=====================================
Files 2 2
Lines 9 9
=====================================
Hits 8 8
Misses 1 1 |
Contributor
Author
|
I have rebased my fork and tested again that this fixes it. |
Contributor
Author
|
@thomasrockhu this one is also important as it fixes reported bug #261 |
Contributor
Author
Comment on lines
+928
to
+932
| cmd = sanitize_arg("", codecov.gcov_exec or "").split(" ") | ||
| cmd.append("-pb") | ||
| if codecov.gcov_args: | ||
| cmd.append(sanitize_arg("", codecov.gcov_args or "")) | ||
| cmd.append(path) |
Contributor
There was a problem hiding this comment.
Suggested change
| cmd = sanitize_arg("", codecov.gcov_exec or "").split(" ") | |
| cmd.append("-pb") | |
| if codecov.gcov_args: | |
| cmd.append(sanitize_arg("", codecov.gcov_args or "")) | |
| cmd.append(path) | |
| cmd = [ | |
| *sanitize_arg("", codecov.gcov_exec or "").split(" "), | |
| "-pb", | |
| sanitize_arg("", codecov.gcov_args or ""), | |
| path, | |
| ] |
Contributor
Author
There was a problem hiding this comment.
That is how I initially had it, but my CI threw some errors with "" entries if gcov_args not supplied. It was trying to find "" as an input file.
Also I split() gcov_exec due to "llvm-cov-6.0 gcov" possibly being passed in.
thomasrockhu
approved these changes
May 29, 2020
Contributor
thomasrockhu
left a comment
thomasrockhu
left a comment
There was a problem hiding this comment.
ok, with the way it is to unblock users, but would prefer a cleaner look
Contributor
Author
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #261