Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Conversation

@thomasrockhu
Copy link
Contributor

@thomasrockhu thomasrockhu commented Jan 22, 2019

This PR fixes the AppVeyor checks

(1) Remove unsupported python versions and add 3.7 to AppVeyor
(2) Skip AppVeyor test that is testing for prefixes.
(3) Update copyright year
(4) Add in vim specific files to .gitignore

PTAL @hootener @stevepeak

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #190 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #190   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files           1      1           
  Lines           1      1           
=====================================
  Misses          1      1

@thomasrockhu thomasrockhu changed the title wip - Update copyright Update AppVeyor and Travis testing Jan 23, 2019
@thomasrockhu
Copy link
Contributor Author

@0xInfection, would love to know the reasoning behind the confusion

@0xInfection
Copy link

@thomasrockhu, there are still many projects which run on Legacy Python. I wonder why you removed support for 2.x versions as unsupported.

@thomasrockhu
Copy link
Contributor Author

@0xInfection, the reason for removing 2.6 testing support is based on pinning coverage and pytest. Given that 2.6.9 was released in October 2013 and has been officially retired, I felt that it wasn't worth continuing to support. Note of course, that 2.7 will still be tested.

However, you bring up a good point that we should be more transparent and communicative about these sort of changes. What would make this an easier transition for you?

@hugovk
Copy link
Contributor

hugovk commented Mar 4, 2019

Here's the pip installs for codecov from PyPI for February 2019:

category percent downloads
2.7 35.76% 237,647
3.6 31.68% 210,532
3.7 13.81% 91,791
3.5 13.50% 89,725
3.4 4.17% 27,692
3.3 0.32% 2,108
3.8 0.32% 2,106
null 0.27% 1,811
2.6 0.12% 824
3.2 0.04% 270
Total 664,506

Source: pypistats python_minor codecov --last-month # pip install pypistats

https://hugovk.github.io/drop-python/2.6/ shows that currently 255/360 of the most downloaded PyPI packages have already dropped Python 2.6


If you add python_requires='>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*', as an argument to setup() in setup.py, then pip will install the correct version for the user's running Python.

Make sure to use recent pip, setuptools and wheel when releasing to include the metadata in the package.

@hugovk hugovk mentioned this pull request Mar 4, 2019
@thomasrockhu thomasrockhu merged commit 2fb24e2 into master Mar 14, 2019
@thomasrockhu thomasrockhu deleted the fix/appveyor-tests branch March 14, 2019 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants