This repository was archived by the owner on May 21, 2025. It is now read-only.
Include the cacert in the PUT call when uploading to S3 #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@thomasrockhu I can create a new PR for this issue with conflicts resolved if you would like. |
Contributor
|
@nmoinvaz yes please, or resolve conflicts, your choice |
Contributor
|
I don't have the ability to edit the PR so I created #266 based on updated commit. |
Contributor
|
Closed via #266 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
verify=codecov.cacertargument to theput()call when uploading results to S3. This resolves a problem where a user-specified CACert file is required to successfully connect to the codecov server. The initial connection to codecov ('Pinging codecov...') includes the CACert and is successful, but the subsequent upload fails because the CACert was not included.