Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.
This repository was archived by the owner on May 21, 2025. It is now read-only.

Failure in the gcov processing find command, whose test is AWOL #247

@fish2000

Description

@fish2000

The gcov processing command issued by codecov contains malformed find predicates, and always fails. The failure looks like this:

Screen Shot 2020-04-08 at 1 45 10 AM

… this is on macOS, which offers BSD find as the default. I verified the failure by installing GNU findutils with Homebrew and changing a local clone of codecov to use that (as /usr/local/bin/gfind) – the error message is slightly more helpful:

`/usr/local/bin/gfind /Users/fish/Dropbox/CLU/clu -not -path './bower_components/**' -not -path './node_modules/**' -not -path './vendor/**' -type f -name *.gcno  -exec gcov -pb  {} +` exited with status 1, error: “gfind: paths must precede expression: `'

… the relevant gcov-related test is, I think, the only test in the codecov suite that is completely commented out and skipped:

    def test_gcov(self):
        self.skipTest("Need to fix this test...")
        # if self._env.get('TRAVIS') == 'true':
        #     self.write_c()
        #     output = self.run_cli(token='a', branch='b', commit='c')
        #     self.assertEqual(os.path.exists('hello.c.gcov'), True)
        #     report = output['reports'].split('<<<<<< network\n')[1].splitlines()
        #     self.assertIn('hello.c.gcov', report[0])
        # else:
        #     self.skipTest("Skipped, works on Travis only.")

… which suggests at least an acknowledgement of the problem, if not a genesis of same.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions