Bump checkstyle 9.2 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dachucky
commented
Dec 22, 2021
dachucky
commented
- Bumping checkstyle to latest version, 9.2 and updated incompatible config
- Updated Java version based on currently available version for openjdk8-jre in alpine-3.10
Version of openjdk-jre available for alpine-3.10 is 8.275.01-r0. See https://pkgs.alpinelinux.org/packages?name=openjdk8-jre&branch=v3.10
MAINTAINER is deprecated, replaced with using LABEL. See https://docs.docker.com/engine/reference/builder/#maintainer-deprecated
scope was changed to accessModifiers in Checkstyle 8.42. See https://checkstyle.sourceforge.io/releasenotes.html#Release_8.42 and checkstyle/checkstyle#7417
f-moya
approved these changes
Jan 24, 2022
Contributor
f-moya
left a comment
f-moya
left a comment
There was a problem hiding this comment.
Thanks for submitting this, it looks good!
Contributor
|
@dachucky this update is available through the # .codeclimate.yml
plugins:
checkstyle:
enabled: true
channel: beta
|
f-moya
added a commit
that referenced
this pull request
Mar 10, 2022
|
@fede-moya do you remember the reason of this bump ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.