Skip to content

Plagiarism Services & Minor Improvements#31

Merged
Bhupesh-V merged 11 commits intodevfrom
plag-services
Jan 18, 2020
Merged

Plagiarism Services & Minor Improvements#31
Bhupesh-V merged 11 commits intodevfrom
plag-services

Conversation

@Bhupesh-V
Copy link
Copy Markdown
Contributor

@Bhupesh-V Bhupesh-V commented Jan 18, 2020

No description provided.

@Bhupesh-V
plagiarism services WIP
92216fb 
- Issue : #25
- updated dependencies
- new endpoint: /plagiarism-detector
@Bhupesh-V
Update File Submission Path
b9e44ed 
- reduced the nested directory structure for file submission
- new location MEDIA_ROOT/submissions/assignments/<assg_id>/
@Bhupesh-V
wrote changelog
e815c9b
@Bhupesh-V
major changes & bug fixes
5782001 
- Only One Solution object is created (OneToOne)
- moved all Auth & Permission classes to settings
- Update/Delete Views for Questions, Submissions & Assignments (New End-points)
- Now ID is also returned for listing Submissions
@Bhupesh-V
few updates
02d1164 
- new check for plagiarism field in Question Model #9
- Partially fixes #24
@Bhupesh-V
update migration
f54f6c4
@Bhupesh-V
minor changes & bug fixes
7732fe5 
- fixed a bug where submitting a solution for different user resulted in Unique Validator
- cleaned & renamed Endpoints
- Plagiarism Service WIP
@Bhupesh-V
fix #21
731e9fb 
- A standard 404 is returned on accessing /media URLs
- In .env set DEBUG = '' is equal to DEBUG = False
@Bhupesh-V
Plagiarism Service #25 (Alpha Stage)
84fc75a 
- Renamed service to codesim
- PlagiarismView works now 😉
@Bhupesh-V
minor improvements
4c5dbd1 
- Fix #29
- New Fields are returned in codesim utility
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Jan 18, 2020 •
edited
Loading

Hello @Bhupesh-V! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 35:80: E501 line too long (86 > 79 characters)
Line 36:80: E501 line too long (80 > 79 characters)
Line 37:80: E501 line too long (84 > 79 characters)
Line 44:80: E501 line too long (85 > 79 characters)
Line 49:80: E501 line too long (81 > 79 characters)
Line 52:80: E501 line too long (85 > 79 characters)
Line 53:80: E501 line too long (88 > 79 characters)

Line 74:80: E501 line too long (113 > 79 characters)

Comment last updated at 2020-01-18 13:13:47 UTC

@Bhupesh-V Bhupesh-V changed the title Plagiaris Services & Minor Improvements Plagiarism Services & Minor Improvements Jan 18, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2020 •
edited
Loading

Codecov Report

Merging #31 into dev will decrease coverage by 5.14%.
The diff coverage is 48%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #31      +/-   ##
=========================================
- Coverage   70.94%   65.8%   -5.15%     
=========================================
  Files          19      20       +1     
  Lines         444     500      +56     
=========================================
+ Hits          315     329      +14     
- Misses        129     171      +42
Impacted Files Coverage Δ
api/urls.py 100% <ø> (ø) ⬆️
app/migrations/0001_initial.py 0% <ø> (ø) ⬆️
utilities/judge.py 16% <0%> (-1.4%) ⬇️
codeclassroom/settings.py 100% <100%> (ø) ⬆️
app/serializers.py 88.31% <100%> (ø) ⬆️
utilities/codesim.py 29.41% <29.41%> (ø)
app/models.py 85.41% <58.33%> (-2.96%) ⬇️
api/views.py 58.78% <67.3%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5c41a...9d3a262. Read the comment docs.

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 18, 2020

This pull request introduces 2 alerts when merging 4c5dbd1 into fa5c41a - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@Bhupesh-V
style fixes & CHANGELOG updates
9d3a262 
- fix lgtm problems
- fix PEP
@Bhupesh-V Bhupesh-V merged commit ee28520 into dev Jan 18, 2020
@Bhupesh-V Bhupesh-V deleted the plag-services branch January 18, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bhupesh-V @pep8speaks