Skip to content

minor imporovement & bug fixes#28

Merged
Bhupesh-V merged 6 commits intodevfrom
b-features
Jan 9, 2020
Merged

minor imporovement & bug fixes#28
Bhupesh-V merged 6 commits intodevfrom
b-features

Conversation

@Bhupesh-V
Copy link
Copy Markdown
Contributor

@Bhupesh-V Bhupesh-V commented Jan 9, 2020

Issues resolved #17 #11 #12

@Bhupesh-V
few improvements
dc05e01 
- separate logic from views, new utilities app for email, judge and plagiarism services
- fixes issue #12
- update Django and drf to secure versions
@Bhupesh-V
fix #11
1ce3930
@Bhupesh-V
migrated code running facility to utilities app
78d9cbb 
- bump coderunner to 0.5
- 2 new functions run_code() and submit_code()
@Bhupesh-V
model changes
cdd4ccb 
- new PlagResult model #17
- new moss_key field in Professor model
- Support for New languages PHP, Bash
@Bhupesh-V
minor improvemets & bug fixes
461afcb 
- cleaned judge.py (remove duplicate code)
- fixed the bug where a new file was saved for every submission
- Submission status is set to 'not-attempted' by default now
@Bhupesh-V
model changes
cd4fa9d
@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Jan 9, 2020

Hello @Bhupesh-V! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 26:80: E501 line too long (90 > 79 characters)
Line 28:80: E501 line too long (176 > 79 characters)
Line 35:80: E501 line too long (82 > 79 characters)
Line 48:80: E501 line too long (90 > 79 characters)
Line 56:80: E501 line too long (105 > 79 characters)
Line 68:80: E501 line too long (230 > 79 characters)
Line 69:80: E501 line too long (137 > 79 characters)
Line 80:80: E501 line too long (107 > 79 characters)
Line 81:80: E501 line too long (84 > 79 characters)
Line 89:80: E501 line too long (114 > 79 characters)
Line 90:80: E501 line too long (153 > 79 characters)
Line 91:80: E501 line too long (153 > 79 characters)
Line 95:80: E501 line too long (90 > 79 characters)
Line 96:80: E501 line too long (112 > 79 characters)
Line 97:80: E501 line too long (141 > 79 characters)
Line 98:80: E501 line too long (141 > 79 characters)
Line 106:80: E501 line too long (90 > 79 characters)

Line 36:80: E501 line too long (91 > 79 characters)
Line 46:80: E501 line too long (89 > 79 characters)
Line 121:80: E501 line too long (83 > 79 characters)
Line 133:80: E501 line too long (100 > 79 characters)
Line 134:80: E501 line too long (100 > 79 characters)
Line 135:80: E501 line too long (91 > 79 characters)
Line 136:80: E501 line too long (91 > 79 characters)

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 9, 2020 •
edited
Loading

Codecov Report

Merging #28 into dev will increase coverage by 2.28%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #28      +/-   ##
==========================================
+ Coverage   68.66%   70.94%   +2.28%     
==========================================
  Files          16       19       +3     
  Lines         418      444      +26     
==========================================
+ Hits          287      315      +28     
+ Misses        131      129       -2
Impacted Files Coverage Δ
app/migrations/0001_initial.py 0% <0%> (ø) ⬆️
codeclassroom/settings.py 100% <100%> (ø) ⬆️
utilities/tests.py 100% <100%> (ø)
utilities/judge.py 17.39% <17.39%> (ø)
api/views.py 60.38% <20%> (+9.29%) ⬆️
app/serializers.py 88.31% <50%> (-1.03%) ⬇️
app/storage.py 62.5% <62.5%> (ø)
app/models.py 88.37% <95.65%> (+1.6%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 654f116...cd4fa9d. Read the comment docs.

@Bhupesh-V Bhupesh-V merged commit fa5c41a into dev Jan 9, 2020
@Bhupesh-V Bhupesh-V deleted the b-features branch January 9, 2020 07:42
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 9, 2020

This pull request fixes 1 alert when merging cd4fa9d into 654f116 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Bhupesh-V @pep8speaks