Repository navigation
Conversation
…eceptjs#5807) With a `multiple` config, run-workers set each worker's output to <output>/<run>_<browser>N but never created it, so tests writing into output_dir failed with ENOENT unless a plugin created the folder first. Also remove the folder left behind by the custom output folder name test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5807
Problem
With a
multipleconfig,run-workers N <run>sets each worker's output to<output>/<run>_<browser>N, but it creates only the rootoutput/folder. A test that writes intooutput_dirbefore a plugin creates the folder fails withENOENT.run-multipledoesn't have this problem, because each child process creates its own output folder throughrun.Changes
lib/workers.js:createWorkerObjects()now callsmkdirp.sync()on each worker'srunOutputDirright after computing it.test/runner/run_workers_test.js:should create output directory of each run in multi-run. It uses a new sandbox config without plugins (codecept.workers-multiple-output.conf.js), so nothing else creates the folders. It fails without the fix.should create output folder with custom nametest now removesthisIsCustomOutputFolderName/after the check. It used to stay behind intest/data/sandboxas an untracked folder.Tests
data.txtis written into bothdefault_chromium1/anddefault_webkit1/.npx mocha test/runner/run_workers_test.js: 43 passing.npx mocha test/unit/worker_test.js: 13 passing, 2 pending.🤖 Generated with Claude Code