Could you please verify if the screenshot works correctly in reports? There was a previous issue with a broken screenshot link in reports, so it would be helpful to have a check. Thank you.

The fix was:
#4889

@kobenguyent - correct, it's now working for unique and non-unique screenshots.

Report:

With output directory like:

@Lando1n may you think we could add some UTs for those changes in https://github.com/codeceptjs/CodeceptJS/blob/3.x/test/unit/plugin/screenshotOnFail_test.js

@Lando1n may you think we could add some UTs for those changes in https://github.com/codeceptjs/CodeceptJS/blob/3.x/test/unit/plugin/screenshotOnFail_test.js

For sure, will add.

@kobenguyent - added some tests, but they were reliant on a small Mochawesome helper modification in order to properly mock.

@kobenguyent - any idea why mochawesome isn't a dependency already? Seeing that test failure.

@kobenguyent - any idea why mochawesome isn't a dependency already? Seeing that test failure.

I guess we shall keep this mochawesome as dev-deps right @DavertMik ?

Is it fixed in 3.7.3?

I'm just trying 3.7.3 with uniqueScreenshotName: true and I'm getting this:

The real screenshot name is different than the name expected by the Mochawesome helper: /home/mirao/workspace/codeceptjs/tests/s4e/output/dev_firefox_3/S4E_-_Student_1__Verify_the_assignment_0FWieP4i2hJpSjo_68M8lbyTGMfQrOjo8iylrSqeza.failed.png

3.6.10 isn't affected.

I'm just trying 3.7.3 with uniqueScreenshotName: true ....

Just checked that it works well with uniqueScreenshotName: false

OK, I incorporated changes from this task to my CodeceptJS project and then it works well - the screeenshot name in Mochawesome report matches the real name created in the output folder.

So I guess the fix will be released in 3.7.4?