feat(puppeteer): network traffics manipulation#4263
Merged
kobenguyent merged 7 commits into3.xfrom Mar 23, 2024
Merged
Conversation
DavertMik
requested changes
Mar 18, 2024
Contributor
DavertMik
left a comment
DavertMik
left a comment
There was a problem hiding this comment.
There is no plural for traffic and share
so better to rename "networkTraffics" => network
"shares" => "share"
but maybe we don't need this share?
it is already shared
| @@ -0,0 +1,123 @@ | |||
| const assert = require('assert'); | |||
| const { isInTraffic, createAdvancedTestResults, getTrafficDump } = require('../utils'); | |||
Contributor
There was a problem hiding this comment.
why do we need shares folder for that?
Collaborator
Author
There was a problem hiding this comment.
Those are the same pieces of code that appeared in 3 helpers. So I wanna move them to a shared folder which is better than copy/paste the same code in 3 helpers.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
🛩️ Features
startRecordingTrafficgrabRecordedNetworkTrafficsflushNetworkTrafficsstopRecordingTrafficseeTrafficdontSeeTrafficExamples:
Applicable helpers:
Type of change
Checklist:
npm run docs)npm run lint)npm test)