Skip to content

fix: updated performSwipe with w3c protocol#4154

Merged
kobenguyent merged 21 commits intocodeceptjs:3.xfrom
MykaLev:performeSwipe-updated-to-w3c-protocol
Feb 2, 2024
Merged

fix: updated performSwipe with w3c protocol#4154
kobenguyent merged 21 commits intocodeceptjs:3.xfrom
MykaLev:performeSwipe-updated-to-w3c-protocol

Conversation

@MykaLev
Copy link
Contributor

@MykaLev MykaLev commented Jan 24, 2024

Motivation/Description of the PR

Applicable helpers:

  • Appium

Type of change

  • 🐛 Bug fix

Checklist:

  • Lint checking (Run npm run lint)

@MykaLev MykaLev changed the title updated performSwipe with w3c protocol fix: updated performSwipe with w3c protocol Jan 25, 2024
kobenguyent and others added 6 commits January 25, 2024 13:52
@kobenguyent
fix: I.say would be added to Test.steps object (codeceptjs#4145)
cd4288e
@kobenguyent
release 3.5.12 (codeceptjs#4156)
439364e 
* release 3.5.12
@dyaroman
fix(webapi): selectOption method (codeceptjs#4157)
4837073 
trim text content value
@actions-user
DOC: Update contributor faces
795f5d2
@MykaLev
fixed typescript parameter inputs count
a40285d
@dependabot
chore(deps-dev): bump testcafe from 3.3.0 to 3.5.0 (codeceptjs#4160)
69e0a0e 
Bumps [testcafe](https://github.com/DevExpress/testcafe) from 3.3.0 to 3.5.0.
- [Release notes](https://github.com/DevExpress/testcafe/releases)
- [Changelog](https://github.com/DevExpress/testcafe/blob/master/CHANGELOG.md)
- [Commits](DevExpress/testcafe@v3.3.0...v3.5.0)

---
updated-dependencies:
- dependency-name: testcafe
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kobenguyent
kobenguyent reviewed Jan 29, 2024
View reviewed changes
lib/helper/Appium.js Outdated
*
* ```js
* I.performSwipe({ x: 300, y: 100 }, { x: 200, y: 100 });
* I.performSwipe(elementId, { x: 300, y: 100 }, { x: 200, y: 100 });
Copy link
Collaborator

@kobenguyent kobenguyent Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to performSwipe without passing the elementId?

Copy link
Contributor Author

@MykaLev MykaLev Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id: - is mandatory attribute of the w3c call. But can be used some random string inside the method instead of elementId parameter

Copy link
Collaborator

@kobenguyent kobenguyent Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That'll be great if we could implement like that. Cause we actually perform swipe without knowing any element id.

Copy link
Contributor Author

@MykaLev MykaLev Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed elementId but after merge after sync with main repo I got some extra files changes. Not sure why

@MykaLev
Copy link
Contributor Author

MykaLev commented Feb 2, 2024

Is there any blocker from merging this PR?

@kobenguyent kobenguyent merged commit 3b34ae6 into codeceptjs:3.x Feb 2, 2024
kobenguyent added a commit that referenced this pull request Feb 2, 2024
@kobenguyent
Revert "fix: updated performSwipe with w3c protocol (#4154)"
a91e7bc 
This reverts commit 3b34ae6.
@kobenguyent
Copy link
Collaborator

kobenguyent commented Feb 2, 2024

unfortunately, it broke our appium tests.
3b34ae6

@MykaLev
Copy link
Contributor Author

MykaLev commented Feb 5, 2024

Which tests were broken. And where can I find the report?

@kobenguyent
Copy link
Collaborator

kobenguyent commented Feb 5, 2024

Please check them here:

  1) Appium
       #makeTouchAction
         run simplified swipeDown @quick:

      AssertionError [ERR_ASSERTION]: 'LONG PRESS' == 'FLICK'
      + expected - actual

      -LONG PRESS
      +FLICK
      
      at Context.<anonymous> (test/helper/AppiumV2_test.js:324:14)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

1) Appium
       #makeTouchAction
         #performTouchAction
           should react on swipeUp action @second:
     Error: Element "//android.widget.TextView[@resource-id = 'io.selendroid.testapp:id/text_view4']" was not found by text|CSS|XPath
      at new ElementNotFound (lib/helper/errors/ElementNotFound.js:15:11)
      at assertElementExists (lib/helper/WebDriver.js:2889:11)
      at Appium.grabTextFrom (lib/helper/WebDriver.js:1261:5)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async Context.<anonymous> (test/helper/AppiumV2_test.js:[43](https://github.com/codeceptjs/CodeceptJS/actions/runs/7758085065/job/21159026729#step:5:44)5:20)

  2) Appium
       #makeTouchAction
         #performTouchAction
           should react on swipeDown action @second:
     Error: Element "//android.widget.TextView[@resource-id = 'io.selendroid.testapp:id/text_view4']" was not found by text|CSS|XPath
      at new ElementNotFound (lib/helper/errors/ElementNotFound.js:15:11)
      at assertElementExists (lib/helper/WebDriver.js:2889:11)
      at Appium.grabTextFrom (lib/helper/WebDriver.js:1261:5)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async Context.<anonymous> (test/helper/AppiumV2_test.js:[45](https://github.com/codeceptjs/CodeceptJS/actions/runs/7758085065/job/21159026729#step:5:46)0:20)

@MykaLev MykaLev mentioned this pull request Feb 6, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kobenguyent kobenguyent kobenguyent left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MykaLev @kobenguyent @dyaroman @actions-user