fix(questionnaire): fixed whitespace and readded agreements to edit page#582
Merged
cbaudouinjr merged 3 commits into2.2.1from Feb 14, 2021
Merged
fix(questionnaire): fixed whitespace and readded agreements to edit page#582cbaudouinjr merged 3 commits into2.2.1from
cbaudouinjr merged 3 commits into2.2.1from
Conversation
cbaudouinjr
requested changes
Feb 9, 2021
Co-authored-by: Chris Baudouin, Jr. <cjb5326@rit.edu>
peterkos
reviewed
Feb 13, 2021
Contributor
peterkos
left a comment
peterkos
left a comment
There was a problem hiding this comment.
Not showing up for me for some reason.
- Used old db (try with clean)
- Migrate
- Add two agreements
- Create questionnaire w/ admin account, accept agreements
4.5) Verify agreements table exists and are recorded in database - Go to questionnaire
- No agreements card visible at all
Contributor
|
Also protip tables are great for showing multiple screenshots alongside each other 😉 |
cbaudouinjr
approved these changes
Feb 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed the whitespace which was caused by label being a empty string instead of false so the label space was still there. The agreements were also re added although disabled for a director to change.
new:
previous:
possible alternative:
