Conversation
made a page to to view upcoming events in the management tools
calendar has all the features needed need to make it less janky and possible add/remove features based on feedback
created a page to view, make, and delete events. These events contain a title, description, location, owner(s), if it is a public and/or all day event and when it starts and stops.
made the code comply with houndci-bot requests and removed the all day bool for a event
implemented owners in a similar way to message recipients it will only allow for the selection of admin user as the owner(s) of a event. No owners it also allowed.
|
blocked by issue-222 |
# Conflicts: # Gemfile.lock
There was a problem hiding this comment.
Great work! Apologies for the infinite delay on my review.
I'll review the API tomorrow when I can check in with how we're implementing it on brickhack.io to get a real feel for it. Also make sure to backmerge from 2.2!
Notes:
- What time zone is this intended for? Whatever the server runs on? Should we allow for hackathons to set that as a config option, or here in the schedule? (Prob as separate issue unless its ez to implement)
- Not everyone might be comfortable working in 24hr time; how easy would it be to make this 12hr time with PM/AM?
- A little more coverage on the
rendermethods ofevents-controller.rbwould be great if you could throw those in!
Suggestions:
- Tests seem very access-oriented rather than behavior-oriented; a test for the below bug would be great to add in there!
- Bug: can create events with earlier finish than start date (time or day)
| Edit | Applied |
|---|---|
![]() |
![]() |
- Should have
pointer: cursor;on event row hover - Remove extra
ml-1 mr-1margin around form items, making them unaligned:
(Not sure how easy to fix, seems to be from simpleform's bootstrap styling)
|
the time zone is utc-0 I am assuming we could add a timezone in the config but I don't think that would be necessary since that would not change anything with how the information is displayed changing time to a am/pm is not supported by simpleform so this should be held off for a simple form refactor I fixed the save button bug by manually setting the submit button text. I have no idea why this bug exists though since that was not required in other forms |
* build: Reduces CHECKS attempts to 100 from 300 (#495) * build: Updates GitHub Actions to work on all version branches (#509) * feature: Adds Users & Staff docs (#497) * fix: Resolves job execution failure on nil questionnaires (#529) * feat: Adds event calendar support (#259) * build(deps): Upgrade yarn * build(deps): Upgrade gems * build(deps): Remove obsolete gems * v0.0.0 * build(deps): Update semantic-release * feat(events): add upcoming events page made a page to to view upcoming events in the management tools * feat(events): added page to make new events * added gem.lock * functionally complete calendar calendar has all the features needed need to make it less janky and possible add/remove features based on feedback * feat(events):page to view and make upcoming events created a page to view, make, and delete events. These events contain a title, description, location, owner(s), if it is a public and/or all day event and when it starts and stops. * fix: corrected formating errors and removed all day option made the code comply with houndci-bot requests and removed the all day bool for a event * fix: removed left over allDay refernce * fix: corrected houndci format suggestion * feat(event): added owners as a list of admins only implemented owners in a similar way to message recipients it will only allow for the selection of admin user as the owner(s) of a event. No owners it also allowed. * fix(events): refactored to work with latest 2.0 altered new manage sidebar to include events and fixed bug in event model testing * Fixed issue on desktop * feat(event): removed unneeded form options removed owner and public options from event creation form since they are no longer relevent for the intended purpose of this schedule * Map overflow scroll Signed-off-by: Peter Kos <pkos91@icloud.com> * Fix scroll issue Signed-off-by: Peter Kos <pkos91@icloud.com> * Fixed toggle button; fits screen, sidebar width Sidebar width is better Toggle button fills height of navbar Signed-off-by: Peter Kos <pkos91@icloud.com> * fix: Allows optional assets to be unset * fix(events):added basic testing added the basic tests and renamed "end" to "finish" in event * Fixes test * fix(event): tweak test in attempt to get working * fix(event): got testing to work for some reason there is a flow for how redirects works for a controller. The index goes to the correct redirect but the create does not. * fix(event): fix hound errors and db password error accidently pushed local db password and corrected hound errors * fix(event): fix houndci error i missed * feat: Redesigns OAuth2 portal (#404) * feat: Redesigns OAuth2 portal * fix: Some Hound issues * Changes application verbiage * Fixes ID issue * Fixes table link and sign out button * Peter's wishes * Adds Redis dump files to .gitignore * fix(event): fixed some of the pull request suggestions * Shorten form :) Signed-off-by: Peter Kos <pkos91@icloud.com> * fix(forms): change size of all forms without textbox changed the style of all forms that don't have a large text area or other aspects of the form that make a full length form perferable. With the exception of those forms all forms are now more narrow * fix(event): implemented pull request changes fixed cancel button and removed blue dot in list. decided to use simple form datetime picker instead of html datetime-local input because firefox does not support it. * fix: Fixes MyMLH branding in config (#412) * feat(settings): Simplifies Config (#409) * feat(settings): Simplifies Config * Resolves Hound issues * Update app/views/manage/configs/index.html.haml Co-authored-by: Peter Kos <pkos91@icloud.com> * design: Increases the font-weight and reorganizes the page * fix: Hound issues Co-authored-by: Peter Kos <pkos91@icloud.com> * feat: Adds support for digital-only hackathons (#395) * feat: Adds support for digital-only hackathons * fix: Provides clarity for what is removed from digital hackathons Co-authored-by: Peter Kos <pkos91@icloud.com> * event(fix): renamed events to schedule and reverted forms change event to schedule on the mangage sidebar and undid change to forms * feat: Adds GitHub Action for releases (#426) * feat: Adds GitHub Action CI testing (#423) * feat: Adds GitHub Action CI testing * fix: Adds sudo * refactor: Changes naming * Removes travis.yml * docs: Adds ruby version comment * fix(event): schedule now shows end time do to issues with "end" being a keyword in rails and what fullcalendar uses for events ending end time was previously not showing up * fix(event): fix houndci complaints * bundle install * fixed styling errors and added check for finish and start time * made finish time optional and made css fixes * fix houndci complaint * fix houndci complaint part 2 * removed finish time requirement in test Co-authored-by: Chris Baudouin, Jr <chrisbaudouinjr@icloud.com> Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> Co-authored-by: Peter Kos <pkos91@icloud.com> * fix(sidebar): side bar title now matches sidebar width (#537) * side bar title now matches sidebar width * made sidebar narrower Co-authored-by: Peter Kos <pkos91@icloud.com> * feature: Allows directors to change user's names (#530) * refactor: Changes register to "Create an Account" (#541) * security: Adds rel="noopener" to all target="_blank" (#494) * security: Adds rel="noopener" to all target="_blank" * feature: Adds additonal rel="noopener" Co-authored-by: Peter Kos <pkos91@icloud.com> * refactor(Users): Shows user's name on show/edit pages (#483) Co-authored-by: Peter Kos <pkos91@icloud.com> * fix: Questionnaire agreement read and accept error placement (#525) Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> * fix(agreements): decreased distance between icons (#542) Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> * feat(map): Hides map on mobile and added button to show it (#538) * hide map on mobile and added button to show it * map button text now changes when map is open * fix houndci errors Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> * build(deps): Updates shoulda and shoulda-matchers (#482) * master <- develop (2.1.2) (#472) (#478) * fix(questionnaire): missing information now in correct place (#443) * fix(questionnair): missing information now in correct place it now displays the correct message "Please read & accept" instead of missing information and the notification is now in the correct place * Update app/assets/javascripts/validate.js * Revert "Update app/assets/javascripts/validate.js" This reverts commit bc54783. Signed-off-by: Peter Kos <pkos91@icloud.com> Co-authored-by: Peter Kos <pkos91@icloud.com> * fix: Fixes mobile agreements layout bug Signed-off-by: Peter Kos <pkos91@icloud.com> * feat: Removes semantic-release (#446) * refactor: Moves CI to develop branch (#449) Co-authored-by: Peter Kos <pkos91@icloud.com> * build: Merges 2.1.2 into develop * fix(hakiri): corrected unescaped model attribute * fix(hakiri): added html_safe to show proper output Co-authored-by: Jeremy Rudman <jeremyrudman@gmail.com> Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> * fix: Shows questionnaires_closed_message on registration * feat: Allows agreements to be fully customizable (#465) * feat: Allows agreements to be fully customizable * fix: Fixes broken migrations * fix: Migrations misname issue * feat: Forces agreement links to open in new tab * Agreement validation detection fixed Signed-off-by: Peter Kos <pkos91@icloud.com> * refactor: Removes old input hint Co-authored-by: Peter Kos <pkos91@icloud.com> * fix(hakiri): fixed un-escaped regex for vcs link (#467) * fix(hakiri): corrected unescaped model attribute * fix(hakiri): added html_safe to show proper output * fix(hakiri): added \A \z to regex * fix(questionnaire): fixed hakiri error with vcs link regex * fix(questionnaire): fixed houndci commplaint Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> * fix(hakiri): fix hakiri error with user input in html_safe (#475) Co-authored-by: Peter Kos <pkos91@icloud.com> Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> Co-authored-by: Jeremy Rudman <jeremyrudman@gmail.com> Co-authored-by: Peter Kos <pkos91@icloud.com> Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> Co-authored-by: Jeremy Rudman <jeremyrudman@gmail.com> * build(deps): Updates shoulda and shoulda-matchers * Update test/test_helper.rb Co-authored-by: Hound <hello@houndci.com> Co-authored-by: Peter Kos <pkos91@icloud.com> Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> Co-authored-by: Jeremy Rudman <jeremyrudman@gmail.com> Co-authored-by: Hound <hello@houndci.com> * refactor: Hides several dangling dietary restrictions in digital mode (#533) * refactor: Hides several dangling dietary restrictions in digital mode * fix: Hides dietary restrictions form questionnaire overview Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> * fix: Fixes white space next to sidebar (#544) Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> * feat(schedule): add category field to schedule (#546) * feat(schedule): add category field to schedule * moved event catorgory addition to a seprate migration * add category and location label for schedule display * made label more semantically nice * more code cleanup for events * Update app/assets/javascripts/events.js Co-authored-by: Peter Kos <pkos91@icloud.com> Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> Co-authored-by: Peter Kos <pkos91@icloud.com> * fix(events): fixed api to be public and have blank strings be null (#552) * fix(events): fixed api to be public and have blank strings be null * made is so category is null on empty string * build: Moves dependabot to develop branch (#507) * build(deps): Updates Sidekiq to 6.1.3 (#461) * build(deps): Updates Sidekiq to 6.1.2 * build: Updates Sidekiq to 6.1.3 * build: Updates sidekiq-cron * refactor: Removes MLH branding from Stats page, moved stats strings to locales (#460) * refactor: Removes MLH branding from Stats page * fix: Updates stats test paths * refactor: Renames several stats tables Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> * fix: Fixes RSVP Reminder email being sent to RSVP attendees (#557) * fix: Add CORS for all API requests (#554) * cors * Do it more properly * hound * cors allowed only on non-manage routes * Resource path does not support regex; even tonly * only allow on gets lol Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> * feat(questionnaire): add country field for questionnaire (#550) * feat(questionnaire): add country field for questionnaire the application now asks for a country to due to MLH requirements * fix houndci complaints * Update app/views/application/_missing_country_notice.html.haml Co-authored-by: Chris Baudouin, Jr. <cjb5326@rit.edu> * added custom error message for missing country for RSVP * fix houndci complaints * Update _missing_country_notice.html.haml Co-authored-by: Chris Baudouin, Jr. <cjb5326@rit.edu> Co-authored-by: Peter Kos <pkos91@icloud.com> * refactor: defined roles do in role selection and refactored readme (#556) * refactor: defined roles do in role selection and refactored readme * Update README.md Co-authored-by: Peter Kos <pkos91@icloud.com> * completed questionnaire page on docs (#512) * completed questionnaire page on docs * Update questionnaires.md * Fix various typos Co-authored-by: Peter Kos <pkos91@icloud.com> Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> * feature: Allows directors to reset passwords through admin portal (#524) Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> Co-authored-by: Peter Kos <pkos91@icloud.com> Co-authored-by: Chris Baudouin, Jr <cjb5326@rit.edu> Co-authored-by: JeremyRudman <38338616+JeremyRudman@users.noreply.github.com> Co-authored-by: Chris Baudouin, Jr <chrisbaudouinjr@icloud.com> Co-authored-by: Jeremy Rudman <jeremyrudman@gmail.com> Co-authored-by: Hound <hello@houndci.com> Co-authored-by: aag5734 <69917471+aag5734@users.noreply.github.com>




screenshots as of 12/10/2020:


