Quiz #1 - if-then-else necessary in order to return a different output depending on a service response #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g on a service response
arialdomartini
added a commit
that referenced
this pull request
Jul 21, 2014
if-then-else necessary in order to return a different output depending on a service response
arialdomartini
changed the title
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quiz
This is an example of a (Java) snippet of code where an
if-then-elseseems pretty natural.We have an imaginary
Formatterclass with a method (doTheJob(String)) performing a trivial feature (it takes a string and it outputs the same string repeated twice).Now, the class performs differently based on the output of its only dependence,
Service.askForPermission()Service.askForPermission()Formatter.doTheJob("foo")"OK""foofoo""FAIL""error"""Apparently, the code is awful. Not only is the
ServiceAPI awful (askForPermission) could return abooleanrather than aString. What's worst, theFormatter.doTheJob()code is a hugeif-then-elsesnippet.This is one of the (extreme?) cases where I think a conditional is pretty hard to remove. Or, at least, where I think the removal could produce a code more awful than the original one.
Can you prove me wrong?