Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: code4lib/shortimer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: code4lib/shortimer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: wikidata
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Sep 22, 2016

  1. wikidata_id

    this is step one in moving form freebase to wikidata. I added wikidata_id
    to the Employer, Location and Subject models. Then I added a migration to
    lookup the existing entities in Wikidata using Wikidata's SPARQL endpoint.
    The matching logic thus far is:
    
    1. Look up entity using the Freebase ID
    2. Use the name of the entity to derive the Wikipedia URL and look that up
    3. To search for the label
    
    The next step is to purge entities that don't have Wikidata IDs, and then
    to create new suggest functionality that uses Wikidata instead of Freebase.
    
    refs #38
    refs #57
    edsu committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    ffb9d7d View commit details
    Browse the repository at this point in the history
  2. handle unicode names better

    edsu committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    2d29753 View commit details
    Browse the repository at this point in the history
Loading