Build Factor from source and prevent the restart message from always being printed #2352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error256
reviewed
Jul 30, 2025
github-actions
bot
added
conflicts
Contributor
Author
|
I'm working on something to ensure Factor can continue reading from STDIN, not declare anything, not import too early, or whatever, but still keep its mouth shut. Unfortunately, it's still a bit of a mess. |
Yewzir
changed the title
Yewzir
changed the title
print-use-hook handler in the vocabs.parser vocabulary
Yewzir
commented
Nov 11, 2025
langs/factor/Dockerfile
Outdated
Comment on lines
12
to
14
| RUN sed -i 's/64//' basis/io/directories/unix/linux/linux.factor \ | ||
| && sed -i 's/lxstat64/lxstat/' basis/unix/stat/linux/64/64.factor \ | ||
| && sed -i '/^\[/,/al/d' basis/vocabs/prettyprint/prettyprint.factor |
Contributor
Author
There was a problem hiding this comment.
The first two are temporary fixes for a successful build, the last one removes the following:
[
[
nl
{ { font-style bold } { font-name "sans-serif" } } [
"Restarts were invoked adding vocabularies to the search path." print
"To avoid doing this in the future, add the following forms" print
"at the top of the source file:" print nl
] with-style
manifest-style [ manifest get pprint-manifest ] with-nesting
nl nl flush
] with-output>error
] print-use-hook set-globalNothing more or less is imported, only the recurring message is deleted.
Collaborator
There was a problem hiding this comment.
I think this would be better as a patch file, it's more obvious what's going on and less likely to break in subtle ways going forward. In general I think we want to reverse course of swapping patch files for sed as the former are so much clearer and less fragile.
Yewzir
changed the title
print-use-hook handler in the vocabs.parser vocabulary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.