AllTheThings PLC script / Pull review functionality #9490
Conversation
| module Plc::CoursesHelper | ||
| def options_for_user_enrollment_courses | ||
| Plc::Course.all.pluck(:name, :id).sort | ||
| Plc::Course.where.not(name: 'All Of The PLC Things').pluck(:name, :id).sort |
There was a problem hiding this comment.
I didn't want All Of The Things showing up in the dropdown for new enrollments because I didn't want anyone accidentally enrolling in it.
Peer reviewable levels should be submittable by teachers enrolled in plc courses
|
Have to fix one test as well |
mehalshah
force-pushed
the
pull_review_functionality
branch
2 times, most recently
from
a105563 to
c46a42d
Compare
mehalshah
force-pushed
the
pull_review_functionality
branch
from
c46a42d to
6ccd15c
Compare
| result: ActivityConstants::UNSUBMITTED_RESULT, | ||
| icon: '', | ||
| locked: false | ||
| } |
There was a problem hiding this comment.
I'm a bit unclear what this is doing. It adds a new not_started entry to the returned list if the # of existing reviews < # required for the script and a review exists that can be reviewed? Is PeerReview.get_review_for_user called here to see if one is available? But this doesn't persist anything. It just shows the "Review a new submission" option?
There was a problem hiding this comment.
Summarize returns a list of summarized peer reviews for the purpose of rendering level progress dots. This is used on the client side to generate those dots, the same way they are generated for levels.
This part generates a line item that will show up as an empty progress dot that will redirect the user to the pull review path.
So you're right, it doesn't persist anything.
|
few small questions, otherwise LGTM (presuming green test run of course) |
3 participants
Add functionality to now pull a review from the pool when there is one available for the user.
Since TeacherCon script is not ready for peer review, I made a scaled down copy that has peer review enabled.
How to test locally
rake seed:scripts