Run SauceLabs tests on CircleCI #8503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add sauce labs to locals.yml
- Remove extra seeds/setup
…ure—(fixing it from logging out on visits to /hoc/1)
…le based on bundle_require branch
- Require konacha in Gemfile again - Include ActiveSupport keygenerator in cookie helpers
apps/style/common.scss
Outdated
| #visualizationColumn.wireframeShare { | ||
| background: url("#{$common_root}phone_wireframe.png") center center no-repeat; | ||
| background-size: 432px 757px; | ||
| background-color: #5C6971; |
Contributor
Author
There was a problem hiding this comment.
This must have somehow slipped in with a staging merge, will un-do.
Contributor
Author
|
@laurelfan made some changes based on feedback, PTAL! |
Contributor
|
LGTM, nice refactoring and testing of RakeUtils :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes CircleCI run all of our unit tests and optionally run Chrome UI tests.
circle.ymlbehavior updated to:rake installandrake builddashboard/test/uias an artifact folder (to view logs)apps/test.shintotest-low-memory.shand adds a correspondingnpm run test-low-memorytask.format_durations intoRakeUtils.format_durationRakeUtilsto a newGitUtilsmodule@no_circlecircle.rakewith targets that circle uses for running tests and UI testsRakeUtilswhich output toSTDOUTin addition to gathering result information after executiontest.rake, and new test targets:rake test:all- runs all tests across all projectsrake test:changed- detects which sub-projects have changed, runs those testsrake test:changed:apps- runs apps tests if sub-project folder has changedrake test:apps,rake test:pegasus,rake test:blockly_core... etc - runs tests for specific sub-projectAfter (squashed) merging: