Merged
Conversation
| var distanceScaling = constants.SPRITE_COLLIDE_DISTANCE_SCALING; | ||
|
|
||
| if (collidable.isFading && collidable.isFading()) { | ||
| continue; |
Contributor
Author
There was a problem hiding this comment.
Here, you'll notice we do one thing right - we skip items that are already fading out while we loop through items checking collisions. This makes sure you can't collect an item that's already fading out.
Contributor
Author
There was a problem hiding this comment.
Here, you'll notice we do one thing right - we skip items that are already fading out while we loop through items checking collisions. This makes sure you can't collect an item that's already fading out.
Member
|
lgtm, thanks to the detailed description. probably worth testing against other play lab level types to make sure all's good there? |
Contributor
Author
|
Did a quick check of the Minecraft and Gumball scripts, seems like getall behaviors are still good there as expected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only count non-fading items when checking whether we just collected the last item. Explanation of fix inline in diff.
Fixes Pivotal #110267384