Group featured course offerings under "Recommended" - #74641
Draft
bethanyaconnor wants to merge 1 commit into
Draft
Group featured course offerings under "Recommended"#74641bethanyaconnor wants to merge 1 commit into
bethanyaconnor wants to merge 1 commit into
Conversation
CourseOffering#is_featured has existed for some time -- column, levelbuilder checkbox, serialization, seeding -- but its only remaining consumer was a tiebreak in curriculumRecommender.js that never fires, because summarize_for_catalog does not emit the field. Give the flag the two behaviors it was meant to have. Quick assign groups a featured offering under a "Recommended" header in place of the header it was assigned, not in addition to it, so each offering is listed exactly once. "Recommended" sorts ahead of every other header, including "Favorites" and "Year Long". In the grade-band views the group nests inside the offering's curriculum_type and so appears at the top of that column; the HoC, HoAI and PL views get a single group at the top of the first column. The curriculum catalog at /catalog lists featured offerings first, alphabetical by display name within the featured and non-featured groups. Ordering stays server-side, so the catalog filters narrow the list without reordering it. The blank-header and blank-curriculum_type guards are unchanged. Featuring an offering promotes it within quick assign; it does not publish one that curriculum staff have not yet given a header. No migration and no config-file churn. 27 offerings already set is_featured, 22 of which reach the catalog, and they change position on deploy. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CourseOffering#is_featured has existed for some time -- column, levelbuilder checkbox, serialization, seeding -- but its only remaining consumer was a tiebreak in curriculumRecommender.js that never fires, because summarize_for_catalog does not emit the field. Give the flag the two behaviors it was meant to have.
Quick assign groups a featured offering under a "Recommended" header in place of the header it was assigned, not in addition to it, so each offering is listed exactly once. "Recommended" sorts ahead of every other header, including "Favorites" and "Year Long". In the grade-band views the group nests inside the offering's curriculum_type and so appears at the top of that column; the HoC, HoAI and PL views get a single group at the top of the first column.
The curriculum catalog at /catalog lists featured offerings first, alphabetical by display name within the featured and non-featured groups. Ordering stays server-side, so the catalog filters narrow the list without reordering it.
The blank-header and blank-curriculum_type guards are unchanged. Featuring an offering promotes it within quick assign; it does not publish one that curriculum staff have not yet given a header.
No migration and no config-file churn. 27 offerings already set is_featured, 22 of which reach the catalog, and they change position on deploy.
Links
Testing story
Deployment notes
Privacy and security