Skip to content

MUI tooltip: CADS caret pin and trigger gap - #74634

Draft
moshebaricdo wants to merge 1 commit into
stagingfrom
moshebaricdo/mui-tooltip
Draft

MUI tooltip: CADS caret pin and trigger gap#74634
moshebaricdo wants to merge 1 commit into
stagingfrom
moshebaricdo/mui-tooltip

Conversation

@moshebaricdo

@moshebaricdo moshebaricdo commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Draft PR meant for last mile UI tweaks to MUI Tooltip to match CADS: default bottom-start, caret pinned to the aligned edge on -start/-end, and trigger gap of 8px with a tail (4px air + 4px caret) or 6px without.

Links

  • Jira:

Testing story

Deployment notes

Privacy and security

@moshebaricdo @cursoragent
MUI tooltip: CADS caret pin and trigger gap
8f5b902 
Theme-only MUI Tooltip matching CADS: default bottom-start, caret
pinned to the aligned edge on -start/-end, and trigger gap of 8px
with a tail (4px air + 4px caret) or 6px without.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 14, 2026

Copy link
Copy Markdown

🖼️ Storybook Visual Comparison Report

⚠️⚠️⚠️ Detected Storybook eyes differences, see report!

A difference was found in our Storybook front-end visual comparison testing against the staging baseline.
This difference was detected in Applitools Eyes and is viewable in the link above.

Remediation steps:

  1. Open the report
  2. Determine whether the differences are expected based on this PR's changes
    a. If expected: Before merging this PR, accept the new baselines and re-run this action, it should pass.
    b. If not expected: Push updates to this PR to correct the differences.

@moshebaricdo moshebaricdo mentioned this pull request Aug 14, 2026
Merged
@hannahbergam
hannahbergam changed the base branch from staging to hbergam/mui-tooltip-keyboard August 14, 2026 17:09
@hannahbergam
hannahbergam changed the base branch from hbergam/mui-tooltip-keyboard to staging August 14, 2026 17:09
hannahbergam
hannahbergam requested changes Aug 14, 2026
View reviewed changes

@hannahbergam hannahbergam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiiii when I rebase this off of my branch it looks like a ton of changes... can you have your Claude checkout my branch first, and then open a pull request against it so it is only the relevant changes?

@moshebaricdo

moshebaricdo commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Hiiii when I rebase this off of my branch it looks like a ton of changes... can you have your Claude checkout my branch first, and then open a pull request against it so it is only the relevant changes?

On it!

@moshebaricdo

moshebaricdo commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Hiiii when I rebase this off of my branch it looks like a ton of changes... can you have your Claude checkout my branch first, and then open a pull request against it so it is only the relevant changes?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hannahbergam hannahbergam hannahbergam requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moshebaricdo @hannahbergam