Updating song manifest to exclude 6 deprecated songs - #74623
Open
hannahbergam wants to merge 2 commits into
Open
Updating song manifest to exclude 6 deprecated songs#74623hannahbergam wants to merge 2 commits into
hannahbergam wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Dance Party song configuration to retire six songs by switching the default song manifest to a new 2026 manifest and marking/removing the deprecated song IDs from relevant song-selection surfaces.
Changes:
- Switches the default Dance Party manifest filename to
songManifest2026.json. - Marks six additional song IDs as deprecated in the Dance Party frontend song filtering.
- Removes one deprecated song from specific Dance AI level song-selection lists and removes deprecated song artist Twitter handle mappings.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/cdo/shared_constants.rb | Updates the default Dance Party manifest filename used across dashboard/apps. |
| dashboard/config/levels/custom/dance/dance_ai_try_at_measure.level | Removes a deprecated song from the level’s song selection list. |
| dashboard/config/levels/custom/dance/dance_ai_try_at_measure_-k5pilot.level | Removes a deprecated song from the level’s song selection list (K5 pilot variant). |
| dashboard/config/levels/custom/dance/dance_ai_code_at_measure.level | Removes a deprecated song from the level’s song selection list. |
| dashboard/config/levels/custom/dance/dance_ai_code_at_measure_-k5pilot.level | Removes a deprecated song from the level’s song selection list (K5 pilot variant). |
| apps/src/dance/songs.js | Adds the six deprecated song IDs to the deprecated filter list. |
| apps/src/code-studio/dancePartySongArtistTags.js | Removes artist-handle mappings for deprecated songs. |
Suppressed comments (1)
apps/src/code-studio/dancePartySongArtistTags.js:60
- stay_thekidlaroi was removed from SongTitlesToArtistTwitterHandle, but Dance.js builds a tweet string using the handle without checking for undefined. If an existing project still has this selected song, the generated tweet text will include "@undefined".
gee_girlsgen: 'GirlsGeneration',
growingpains_alessiacara: 'AlessiaCara',
// 2022 Songs
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
32
to
36
| // 2020 Songs | ||
| dancemonkey_tonesandi: 'tonesandimusic', | ||
| dernieredanse_indila: 'Indila', | ||
| dontstartnow_dualipa: 'DUALIPA', | ||
| euphoria_loreen: 'LOREEN_TALHAOUI', | ||
| ilkadimisenat_kenandogulu: 'kenandogulu', | ||
| jerusalema_masterkg: 'MasterKGsa', |
Contributor
Author
There was a problem hiding this comment.
The old projects will get an alert message. But to that point @ebeastlake is there another step we should consider regarding share text? Or is this an acceptable outcome considering the error alert we have
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed the instructions in this doc (sidenote- so fun to do a PR completely by hand).
The 6 songs are:
Brendan Dominic Paolini - Ode to Code
Doja Cat - Say So
Kenan Dogulu - Ilk Adimi Sen At
Loreen - Euphoria
The Kid Laroi - Stay
Vanesa Martin - Despedida y Cierre
I was able to follow the instructions and create a project from an old manifest, remove the url param, refresh the page and see this message:
Links
Testing story
Deployment notes
Privacy and security