Remove Deprecated "add2Home" Dependency - #74621
Open
Hamms wants to merge 1 commit into
Open
Conversation
Prep work for the conversion from Sprockets to Propshaft. I can't find any evidence that we've been using this, and I can't get it to appear when using an ios emulator on SauceLabs. My understanding is that we are also moving away from focusing on a mobile-first experience, so rather than taking the time to migrate this dependency to Propshaft, I propose we just remove it. Any objections? Are we actually using this somewhere that I'm not aware of, or do we have any other reason to want to hold on to it? The last relevant PR I could find is from 2015: #4602
Hamms
marked this pull request as ready for review
August 13, 2026 20:20
Hamms
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prep work for the conversion from Sprockets to Propshaft.
I can't find any evidence that we've been using this, and I can't get it to appear when using an ios emulator on SauceLabs.It appears that this does still work on mobile safari, but is broken on chrome on iOS.My understanding is that we are also moving away from focusing on a mobile-first experience, and in general would prefer our application to have consistent behavior on all platforms, so rather than taking the time to migrate this dependency to Propshaft, I propose we just remove it.
Any objections? Are we actually using this somewhere that I'm not aware of, or do we have any other reason to want to hold on to it?
Links
Slack thread
Archived repo
The last relevant PR I could find is from 2015: #4602
Testing story
I can't find any tests that reference this, either by checking for its presence or accommodating its dismissal.