Remove the layering the nav reskin left behind - #74617
Open
stephenliang wants to merge 1 commit into
Open
Conversation
stephenliang
force-pushed
the
stephen/mainline-nav-cleanup
branch
2 times, most recently
from
August 13, 2026 20:31
06270e8 to
255706e
Compare
Mainlining the nav reskin spliced each brand-gated block into its surrounding scope. Where a spliced block set a value that the code right above it had just set, the file now states a choice the cascade had already made. This removes those redundant statements. It touches only declarations the rebrand added; pre-existing rules are left alone, including the ones the rebrand has made unreachable. .primary asked button-with-color for an orange button and then painted it purple. The mixin now takes an optional border color, so .primary passes the purple tokens straight in. .secondary still passes a single color and is unchanged. The hover state of .headerlink dropped its border-bottom, margin-top and padding. The border-bottom reset the orange underline that this stack deleted, and the other two repeat the values the same block sets already. The small-desktop gap band is deleted. It sets gap: 1.5rem for 1024-1268px, and the rule three lines below sets gap: 0 at the same specificity, so the band never applied. Rendering does not change. The two header rules were checked by computed-style parity: 11 header fixtures, 22 viewport widths on both sides of every threshold this change touches, at rest and under driven hover, active and focus-visible. For .primary, which changes the emitted CSS rather than deleting a duplicate, buttons.scss was compiled before and after: the rule differs only in that the orange pair no longer precedes the purple pair that always replaced it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
stephenliang
force-pushed
the
stephen/mainline-nav-cleanup
branch
from
August 13, 2026 22:10
255706e to
d793312
Compare
stephenliang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#74539 spliced each brand-gated CSS block into its surrounding scope. Where a spliced block sets a value that the code just above it has already set, the file now states a choice the cascade had already made. The clearest case asks for an orange button and then paints it purple two lines later, which @cat5inthecradle flagged in review.
This removes those redundant statements. It touches only declarations the rebrand added. Pre-existing rules are left alone, including ones the rebrand has since made unreachable — those are a separate question, not this PR's.
.primaryaskedbutton-with-colorfor an orange button and then painted it purple. The mixin takes an optional border color, so.primarypasses the purple tokens straight in..secondarystill passes a single color and is unchanged..headerlinkdropsborder-bottom,margin-topandpadding. Theborder-bottomreset the orange underline this stack deleted; the other two repeat values the same block already sets.gap: 1.5remfor 1024-1268px, and the rule three lines below setsgap: 0at the same specificity, so the band never applied.Rendering does not change. The two header rules were checked by computed-style parity: 11 header fixtures, 22 viewport widths on both sides of every threshold this change touches, at rest and under driven hover, active and focus-visible states.
.primarychanges the emitted CSS rather than deleting a duplicate, sobuttons.scsswas compiled before and after — the rule differs only in that the orange pair no longer precedes the purple pair that always replaced it.🤖 Generated with Claude Code