Adds Keyboard Nav Instructions to PythonLab FileTabs and Workspace - #73532
Closed
hannahbergam wants to merge 2 commits into
Closed
Adds Keyboard Nav Instructions to PythonLab FileTabs and Workspace#73532hannahbergam wants to merge 2 commits into
hannahbergam wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds visual, keyboard-only hints for navigating PythonLab’s CodeMirror editor and CodeBridge file tabs, to make discoverability of existing keyboard interactions (Enter/Esc and DnD “m”) better for sighted keyboard users.
Changes:
- Wrapes the CodeMirror mount node to host a focus-visible floating hint for entering/exiting edit mode and scrolling.
- Wraps the FileTabs row to host a focus-visible floating hint for tab reordering.
- Adds new SCSS module styles to position and conditionally show hints via
:has(...:focus-visible).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/src/lab2/views/components/editor/CodeEditor.tsx | Adds wrapper + visual keyboard hint beneath the editor. |
| apps/src/lab2/views/components/editor/code-editor.module.scss | Adds wrapper positioning and :has(.cm-scroller:focus-visible)-controlled hint styles. |
| apps/src/codebridge/FileTabs/FileTabs.tsx | Adds wrapper + visual keyboard hint beneath the tab row. |
| apps/src/codebridge/FileTabs/styles/fileTabs.module.scss | Adds wrapper positioning and :has(.label:focus-visible)-controlled hint styles. |
Contributor
Author
|
Closing in favor of an approach that does #74565 first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links
Testing story
Deployment notes
Privacy and security