Web lab 2 network tab: store request data in redux #70744
Merged
+192
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisher-alice
approved these changes
Feb 11, 2026
Contributor
There was a problem hiding this comment.
While here, do we still need updateLinksToNonHtmlFiles?
Contributor
Author
There was a problem hiding this comment.
we don't, but I'll handle that separately.
| ) => { | ||
| const {id, response} = action.payload; | ||
| const request = state.requests.find(r => r.id === id); | ||
| if (request) { |
Contributor
There was a problem hiding this comment.
Should we log if we return a response which doesn't have a corresponding request?
Contributor
Author
There was a problem hiding this comment.
We'll handle that in the network tab (display an appropriate error).
| url: event.request.url, | ||
| body: bodyText, | ||
| status: response ? response.status : undefined, | ||
| timeElapsed: performanceEndTime |
| const doc = parser.parseFromString(file.contents, 'text/html'); | ||
| const urlSuffix = folder ? `${folder}/` : ''; | ||
| addBaseTagToDocument(doc, `${window.location.origin}/${urlSuffix}`); | ||
| addCSPViolationListenerToDocument(doc); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of getting a network tab in web lab 2 set up. In this PR I am storing all request/response data intercepted by the service worker in redux. In addition, I inject a event handler into student html to be notified of content security policy failures (for example, a student trying to access an API outside of the allow list). These failures never make it to the service worker (they are intercepted before a fetch), so they need to be tracked elsewhere.
The data gets sent from the service worker/event handler via a broadcast channel, similar to how our other communication from the service worker occurs. The inner preview reads the message and sends a message up to the html preview component. This component can then write to our redux store, which the future network tab will read from. On level change we clear the list.
There's no visual change here, but here's an example of the data we are logging
Links
Testing story
Tested locally.
PR Creation Checklist: