-
Notifications
You must be signed in to change notification settings - Fork 526
P20-1796: Add unique constraint on lti_courses #70737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
artem-vavilov
wants to merge
5
commits into
P20-1796/remove-duplicate-lti-courses-oneoff
Choose a base branch
from
P20-1796/lti-course-db-unique-constraint
base: P20-1796/remove-duplicate-lti-courses-oneoff
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+63
−9
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ad4b3fa
P20-1796: Add temporary lock to prevent LtiCourse duplicates under co…
artem-vavilov f2e6a8e
P20-1796: Replace LtiIntegration lock with LtiDeployment lock
artem-vavilov 46e654e
P20-1796: Add unique constraint on lti_courses
artem-vavilov 49bec34
P20-1796: Fix lti_courses unique constraint
artem-vavilov 3efc719
Merge remote-tracking branch 'origin/staging' into P20-1796/lti-cours…
artem-vavilov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
...145032_add_unique_index_to_lti_courses_on_lti_integration_id_and_context_id_and_active.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| class AddUniqueIndexToLtiCoursesOnLtiIntegrationIdAndContextIdAndActive < ActiveRecord::Migration[6.1] | ||
| def up | ||
| execute <<~SQL.squish | ||
| CREATE UNIQUE INDEX index_lti_courses_on_context_integration_active ON lti_courses ( | ||
| context_id, | ||
| lti_integration_id, | ||
| (IF(deleted_at IS NULL, TRUE, NULL)) /* MySQL allows multiple NULL values in a unique index */ | ||
| ); | ||
| SQL | ||
| end | ||
|
|
||
| def down | ||
| remove_index :lti_courses, name: :index_lti_courses_on_context_integration_active, if_exists: true | ||
| end | ||
| end | ||
5 changes: 5 additions & 0 deletions
5
...rate/20260211145245_remove_index_from_lti_courses_on_context_id_and_lti_integration_id.rb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| class RemoveIndexFromLtiCoursesOnContextIdAndLtiIntegrationId < ActiveRecord::Migration[6.1] | ||
| def change | ||
| remove_index :lti_courses, %i[context_id lti_integration_id], name: :index_on_context_id_and_lti_integration_id | ||
| end | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CREATE UNIQUE INDEXwill abort this migration as soon aslti_coursescontains any existing duplicate active pair (context_id,lti_integration_idwithdeleted_at IS NULL), and there is no cleanup step in this change to make those rows unique first. In environments that already accumulated duplicates, deploy will fail at migration time; add a pre-index data migration (or equivalent dedupe step) before creating the constraint.Useful? React with 👍 / 👎.