[Experiment] Removed legacy button !important styles #70736
+0
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a legacy global button:active border override (with !important) to reduce interference with newer button styling (notably MUI / DSCO equivalents) and simplify active-state behavior.
Changes:
- Deleted the
button:active:not(.MuiButtonBase-root)rule that forced a light gray border with!important. - Kept the specialized
button.button-active-no-border:activeoverride for cases that intentionally suppress borders.
Comments suppressed due to low confidence (1)
dashboard/app/assets/stylesheets/application.scss:3472
- The inline comment says this rule overrides a
button:activerule above, but that selector was removed in this PR. Please update the comment to reflect what it actually overrides now (likely the basebuttonborder) or remove the outdated reference to avoid confusion when maintaining button styles.
button.button-active-no-border:active {
// This class is needed for when we want to hide the border on
// an active button. (overriding button:active rule above)
border: none !important;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lfryemason
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Experiment] Removed legacy button !important styles
The issue was found by @breville and is described in slack via this link. It appeared after I was working on cfu and adding Mui Button dsco button equivalent. Removing this legacy styles should be the most optimal solution given all the complexity.(Specifically in this PR) If any regressions appear - feel free to revert and share details of regression
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: