Web Lab 2: allow forms but no form actions #70725
Open
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to provide minimal support for forms in Web Lab 2. What we want to support is projects that submit forms via a "submit" button, but all that button does is trigger an event handler that does some benign operation, not write to an external url.
We can support this by allowing forms on the iframe sandbox, but setting
form-actiontononein the content security policy. This allows submit buttons on forms to work, but you must callpreventDefaulton that submit action to avoid throwing a content security policy error.Links
Testing story
Tested locally. Before this a submit button event handler would not work. Now it does, but if you don't call
preventDefaultyou see an error.PR Creation Checklist: