-
Notifications
You must be signed in to change notification settings - Fork 526
Ceara/aitt 1174 artifact projection views #70687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ceara/aitt 1174 artifact projection views #70687
Conversation
etaderhold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great in general! Just a couple minor suggestions, plus it looks like Drone failed after you merged staging so make sure nothing's wrong there.
| // width: 960px; | ||
| // height: 918px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delete these if unused
| width: 800px; | ||
| padding: 50px 40px 40px 40px; | ||
| flex-direction: column; | ||
| // justify-content: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too
| color: var(--text-neutral-primary, #292F36); | ||
| text-align: center; | ||
| font-feature-settings: 'liga' off, 'clig' off; | ||
|
|
||
| /* Body/Body 1 - ExtraStrong */ | ||
| font-family: var(--font-family-body, Figtree); | ||
| font-size: var(--font-size-body-lg, 20px); | ||
| font-style: normal; | ||
| font-weight: 700; | ||
| line-height: var(--font-line-height-body-lg, 28px); /* 140% */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indentation is wonky here
| markdown={`**Question ${id + 1}:** ${question}`} | ||
| /> | ||
| </Typography> | ||
| {/* <BodyOneText>{`ANSWER: ${item.answer}`}</BodyOneText> */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another commented-out bit that seems unneeded
| displayExitTicket(); | ||
| }); | ||
|
|
||
| function displayExitTicket() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we call this one displayLessonHook?
Adds the projections views for lesson hooks and exit tickets.
Exit tickets:




Lesson hooks:

Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Creation Checklist: