Skip to content

Conversation

@mikeharv
Copy link
Contributor

@mikeharv mikeharv commented Feb 6, 2026

This branch is an effort to remove a bunch of things from the Blockly wrapper that doesn't strictly need to be there any more. Primarily this includes utils that were assigned to the wrapper instance for convenience during migration, and monkey patches intended to preserve the old Blockly API that was found throughout apps code. No changes in behavior are expected.

As this PR makes changes to a lot of files, it could be helpful to review individual commits. I pushed changes related to single functions together. Each change has been tested locally for regressions.

Follow-up work

Proposed next steps:

  • Continue removing wrapper functions. (mainBlockSpace and getWorkspaceCode are good next candidates. They were slightly too big for this branch.)
  • Move data stored on the wrapper to a new Blockly data store singleton. (Ex. embeddedWorkspaces, blockLimitMap)
  • Move out initialization logic. Decide if it should be standardized like it is now or more per-lab (custom field registration, etc.)
  • Delete the wrapper (just that easily)

PR Creation Checklist:

  • Tests provide adequate coverage
  • Privacy impacts have been documented
  • Security impacts have been documented
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Follow-up work items (including potential tech debt) are tracked and linked

@mikeharv mikeharv changed the title Mike/shrink wrapper 1 Shrink Blockly Wrapper - Part 1 Feb 6, 2026
@mikeharv mikeharv marked this pull request as ready for review February 6, 2026 18:56
@mikeharv mikeharv requested review from a team, fisher-alice and wilkie February 6, 2026 18:56
Copy link
Contributor

@fisher-alice fisher-alice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Nice! Appreciate how organized your commits are. Even though I don't have the context for a lot of this, the changes seem to make sense! Thanks for taking this on!

@mikeharv mikeharv merged commit 84ec24f into staging Feb 11, 2026
5 checks passed
@mikeharv mikeharv deleted the mike/shrink-wrapper-1 branch February 11, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants