Sketch Lab: mark file as successfully uploaded #70674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodeorg
commented
Feb 6, 2026
| }; | ||
|
|
||
| export type SketchlabProjectFile = Pick<ProjectFile, 'id' | 'url'> & { | ||
| uploadFailed?: boolean; |
Contributor
Author
There was a problem hiding this comment.
uploadFailed was something I added a while ago and is no longer being set or used.
molly-moen
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for turning on Sketch Lab S3 image storage everywhere, this PR adds a flag to successful uploads (
uploaded).To take the save to S3 feature out of experiment, we need to delete the base64 encoding of the image every time we save sources (which is scary!). I only want to do this for images that we are sure have been uploaded successfully, so we can use this flag to only delete the base64 encoding if we have a successful upload to S3.
Testing story
I tested manually that the
uploadedboolean was successfully set and stored to sources when an image is uploaded successfully.