Fixes an overdue work request that slipped through the cracks. Between May 2023 and February 2024, the student race interstitial was broken, causing a gap in our race/ethnicity data for student accounts created during the '23-'24 school year. @juanmanzojr fixed the bug in Feb 2024, but the gap in data remained.

This PR is to show the student race interstitial to accounts created during the affected time period, if the races field is nil or equal to 'closed_dialog'. Even though it has been quite a while, we can collect data for any accounts that are still active. Also refactors the tests for this popup to use the preferred spec style.

Links

JIRA for this PR
Original bug JIRA
Original bug fix PR

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

• Tests provide adequate coverage
• Privacy and Security impacts have been assessed
• Code is well-commented
• New features are translatable or updates will not break translations
• Relevant documentation has been added or updated
• User impact is well-understood and desirable
• Pull Request is labeled appropriately
• Follow-up work items (including potential tech debt) are tracked and linked