Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
151 commits
Select commit Hold shift + click to select a range
4ea2cac
ruby => 3.3.4
snickell Aug 10, 2024
b8efdac
Gemfile.lock: `bundle update cld`, cld => 0.13.0
snickell Aug 10, 2024
3b08a92
Gemfile.lock: `bundle update css_parser`, File.exists? no longer exists
snickell Aug 10, 2024
c2afbb1
yaml.rb: YAML.load only takes one arg with psych
snickell Aug 10, 2024
98a6fca
Gemfile: eyes_selenium => 6.3.7 + `bundle update eyes_selenium` updat…
snickell Aug 10, 2024
2a85afd
bin/dashboard-server loads studio
snickell Aug 10, 2024
e37d4ea
remove our custom fork of sprockets (backport of rails 4=>3, outdated…
snickell Aug 10, 2024
cdb9cda
pycall => 1.5.2
snickell Aug 10, 2024
346468a
ChatClient: print messages in dev too
snickell Aug 10, 2024
30f28ed
Remove workaround from Gemfile marked 'This is a temporary workaround…
snickell Aug 10, 2024
ca474c4
Gemfile.lock: bundle => 2.5.17
snickell Aug 10, 2024
fca7ba2
Remove unnecessary (?) `gem install bundler` step from SETUP.md
snickell Aug 10, 2024
13e355f
Dockerfile: ruby => 3.3.4, and remove unnecessary manual install of b…
snickell Aug 10, 2024
998f918
.drone.yml: use codedotorg/code-dot-org:ruby-3.3.4
snickell Aug 10, 2024
86c00f1
cookbooks: set ruby to 3.3.4, rake to 13.2.1, bundle to 2.5.17 and ge…
snickell Aug 10, 2024
fa47a9e
Redo rake => 13.2.1 upgrade in /Gemfile
snickell Aug 10, 2024
ade3f94
cdo-ruby/.kitchen.yml: use ubuntu-20.04
snickell Aug 10, 2024
fc84ba9
cdo-ruby/.kitchen.yml: enable serverspec verifier (currently was disa…
snickell Aug 10, 2024
f07b5ec
cdo-ruby ruby-build.rb: bump RUBY_BUILD_VERSION to 20240727 so it kno…
snickell Aug 10, 2024
6c9611a
cdo-ruby ruby-build.rb: include RUBY_BUILD_VERSION in tarball names o…
snickell Aug 10, 2024
8924b8a
cdo-ruby ruby-build: switch from serverspec to inspec which we genera…
snickell Aug 10, 2024
99cc85c
cdo-ruby ruby-build.rb: install apt-package list from https://github.…
snickell Aug 10, 2024
168acbd
ruby_spec.rb: convert from serverspec to inspec
snickell Aug 10, 2024
2568561
honeybadger.yml: ensure API key is a string not an int, dev values of…
snickell Aug 10, 2024
00f4bc1
Fix pre-Ruby-3.4 warnings: "___ was loaded from the standard library,…
snickell Aug 10, 2024
fddc4b0
Gemfile: redcarpet =>3.6.0 to fix a warning, see: https://www.redmine…
snickell Aug 10, 2024
5b2cf11
cookbooks/.ruby-version: bump to 3.3.4
snickell Aug 10, 2024
9621c8b
`bundle update docker-api excon` to fix `kitchen create` for dokken d…
snickell Aug 10, 2024
445b360
cookbooks/Gemfile: explicitly require racc, an undeclared dep of test…
snickell Aug 10, 2024
d9d9569
cookbooks/Gemfile.lock: `bundle update berkshelf`
snickell Aug 10, 2024
7981927
cloud_formation.rb: add Date to YAML.load permitted_classes to fix `r…
snickell Aug 10, 2024
985e818
Gemfile: highline => 3.1.0, fixes warnings on `rake adhoc:start`, see…
snickell Aug 10, 2024
9ac1087
Gemfile.lock: `bundle update honeybadger`, speculative fix to https:/…
snickell Aug 10, 2024
8bef80c
Gemfile: add explicit `syslog` to fix Ruby 3.4 deprecation warnings
snickell Aug 10, 2024
36cfd74
profanity_privacy_helper: disable for Java Lab etc, see: https://gith…
snickell Aug 10, 2024
25218bf
Revert "Gemfile.lock: `bundle update honeybadger`, speculative fix to…
snickell Aug 10, 2024
d97eba8
Merge branch 'staging' into seth/ruby-3.3
snickell Aug 15, 2024
4a4709b
Check the honeybadger backend as the test runs
snickell Aug 15, 2024
f058b6e
Gemfile.lock: `bundle update rubocop`
snickell Aug 15, 2024
1589f00
honeybadger_test: assert_equal 'test', config.backend
snickell Aug 15, 2024
ef71860
honeybadger_test: print extensive debug spew
snickell Aug 15, 2024
951d22a
honeybadger_test: search notices for one from honeybadger_error contr…
snickell Aug 15, 2024
c6b78b3
generateSharedConstants.rb: `require 'ostruct'`
snickell Aug 15, 2024
98af791
.rubocop_[todo|new].yml: update for rubocop 1.65
snickell Aug 15, 2024
95fef89
honeybadger_test: cast notice to json before using
snickell Aug 15, 2024
acd278a
Gemfile.lock: `bundle update vcr`
snickell Aug 15, 2024
2ff9e36
fake_dashboard.rb: fix Psych::AliasesNotEnabled: Alias parsing was no…
snickell Aug 15, 2024
78436fc
pegasus/honeybadger.yml: fix NoMethodError: undefined method `=~' for…
snickell Aug 15, 2024
b58b39b
pegasus page.haml: fix undefined method `exists?' for class File
snickell Aug 15, 2024
fe3059d
Gemfile: image_optim apply ruby 3.1 backport to our custom fork
snickell Aug 20, 2024
caa6da9
Merge branch 'staging' into seth/ruby-3.3
snickell Aug 20, 2024
9154bcf
to_crowdin_yaml: accept that 'yes' example will now be "yes"
snickell Aug 20, 2024
b02c146
Merge branch 'staging' into seth/ruby-3.3
snickell Aug 20, 2024
a75d3e0
`bundle install`
snickell Aug 20, 2024
31c2597
Gemfile.lock: `bundle update cld`, cld => 0.13.0
snickell Aug 10, 2024
85422d5
Gemfile.lock: `bundle update css_parser`, File.exists? no longer exists
snickell Aug 10, 2024
449f971
yaml.rb: YAML.load only takes one arg with psych
snickell Aug 10, 2024
90ec147
Gemfile: eyes_selenium => 6.3.7 + `bundle update eyes_selenium` updat…
snickell Aug 10, 2024
4c4233c
bin/dashboard-server loads studio
snickell Aug 10, 2024
9868287
remove our custom fork of sprockets (backport of rails 4=>3, outdated…
snickell Aug 10, 2024
9a9f659
pycall => 1.5.2
snickell Aug 10, 2024
1a352ab
ChatClient: print messages in dev too
snickell Aug 10, 2024
6ee76ad
Remove workaround from Gemfile marked 'This is a temporary workaround…
snickell Aug 10, 2024
d995478
Gemfile.lock: bundle => 2.5.17
snickell Aug 10, 2024
a094937
Remove unnecessary (?) `gem install bundler` step from SETUP.md
snickell Aug 10, 2024
906d8d2
Redo rake => 13.2.1 upgrade in /Gemfile
snickell Aug 10, 2024
36f45c4
honeybadger.yml: ensure API key is a string not an int, dev values of…
snickell Aug 10, 2024
2c8771d
Fix pre-Ruby-3.4 warnings: "___ was loaded from the standard library,…
snickell Aug 10, 2024
bb0855f
Gemfile: redcarpet =>3.6.0 to fix a warning, see: https://www.redmine…
snickell Aug 10, 2024
9db69f7
`bundle update docker-api excon` to fix `kitchen create` for dokken d…
snickell Aug 10, 2024
e1184ca
cloud_formation.rb: add Date to YAML.load permitted_classes to fix `r…
snickell Aug 10, 2024
8c2be14
Gemfile: highline => 3.1.0, fixes warnings on `rake adhoc:start`, see…
snickell Aug 10, 2024
24bd100
Gemfile.lock: `bundle update honeybadger`, speculative fix to https:/…
snickell Aug 10, 2024
c79315c
Gemfile: add explicit `syslog` to fix Ruby 3.4 deprecation warnings
snickell Aug 10, 2024
b1626b1
profanity_privacy_helper: disable for Java Lab etc, see: https://gith…
snickell Aug 10, 2024
be974c7
Revert "Gemfile.lock: `bundle update honeybadger`, speculative fix to…
snickell Aug 10, 2024
c5c0408
Check the honeybadger backend as the test runs
snickell Aug 15, 2024
d5fbf13
Gemfile.lock: `bundle update rubocop`
snickell Aug 15, 2024
4d8b948
honeybadger_test: assert_equal 'test', config.backend
snickell Aug 15, 2024
f85b5c4
honeybadger_test: print extensive debug spew
snickell Aug 15, 2024
aaec90c
honeybadger_test: search notices for one from honeybadger_error contr…
snickell Aug 15, 2024
3284fb8
generateSharedConstants.rb: `require 'ostruct'`
snickell Aug 15, 2024
a0a26f8
.rubocop_[todo|new].yml: update for rubocop 1.65
snickell Aug 15, 2024
81eea5f
honeybadger_test: cast notice to json before using
snickell Aug 15, 2024
470546d
Gemfile.lock: `bundle update vcr`
snickell Aug 15, 2024
cd04709
fake_dashboard.rb: fix Psych::AliasesNotEnabled: Alias parsing was no…
snickell Aug 15, 2024
58ad4ca
pegasus/honeybadger.yml: fix NoMethodError: undefined method `=~' for…
snickell Aug 15, 2024
b398a68
pegasus page.haml: fix undefined method `exists?' for class File
snickell Aug 15, 2024
33fe94c
Gemfile: image_optim apply ruby 3.1 backport to our custom fork
snickell Aug 20, 2024
1512017
honeybadger_test: fix elijah review suggestions, comment changes to test
snickell Aug 22, 2024
c79ae80
Gemfile: fix elijah review suggestions, move Ruby 3.4 deprecation gem…
snickell Aug 22, 2024
1c1026d
Gemfile: switch image_optim back to cdo branch
snickell Aug 22, 2024
0801f17
`bundle install`
snickell Aug 20, 2024
37235ce
`bundle install`
snickell Aug 21, 2024
0ac52f8
Gemfile: fix elijah review suggestions, move Ruby 3.4 deprecation gem…
snickell Aug 22, 2024
cfb26cb
honeybadger_test: fix elijah review suggestions, comment changes to test
snickell Aug 22, 2024
b5893be
Gemfile: switch image_optim back to cdo branch
snickell Aug 22, 2024
3c9d985
Revert "ChatClient: print messages in dev too"
snickell Aug 22, 2024
9aa7e82
Revert "ChatClient: print messages in dev too"
snickell Aug 22, 2024
3ff783f
Merge branch 'staging' into seth/ruby-3.3
snickell Aug 22, 2024
9f96c30
Merge branch 'staging' into seth/ruby-3.3-hold-the-ruby
snickell Aug 22, 2024
993d990
Merge branch 'seth/ruby-3.3-hold-the-ruby' into seth/ruby-3.3
snickell Aug 22, 2024
5fd8967
cookbooks/Gemfile and Gemfile.lock: reduce diff with ruby-3.3
snickell Aug 22, 2024
9cc9c97
cdo-ruby/.kitchen.yml: use ubuntu-20.04
snickell Aug 10, 2024
2ac4472
cdo-ruby/.kitchen.yml: enable serverspec verifier (currently was disa…
snickell Aug 10, 2024
1aac17a
cdo-ruby ruby-build: switch from serverspec to inspec which we genera…
snickell Aug 10, 2024
a361288
ruby_spec.rb: convert from serverspec to inspec
snickell Aug 10, 2024
e12776d
cookbooks/cdo-ruby ruby_spec.rb: switch back to verifying ruby 3.0.5 …
snickell Aug 22, 2024
c9b7cdf
Merge branch 'seth/ruby-3.3-hold-the-ruby' into seth/ruby-3.3
snickell Aug 22, 2024
04d3117
Gemfile.lock: `bundle install`, removes oily_png automatically
snickell Aug 22, 2024
0710b42
cloud_formation.rb: work on ruby 3.0.5 AND 3.3.4
snickell Aug 22, 2024
0d83426
Merge branch 'seth/ruby-3.3-hold-the-ruby' into seth/ruby-3.3
snickell Aug 22, 2024
5c2a549
Merge branch 'staging' into seth/ruby-3.3
snickell Aug 23, 2024
15bcc00
Revert "Revert "Ruby 3.3.4: pre-upgrade everything that can apply to …
snickell Aug 24, 2024
6c5438c
browsers.json: run Firefox tests on Windows 11, workaround sauce VM i…
snickell Aug 24, 2024
2dde88d
full_page_test.rb: temporary test script for debugging applitools eyes
snickell Aug 26, 2024
f6087d9
full_page_test.rb: rubocop
snickell Aug 26, 2024
b2f5e0e
eyes_steps.rb: try to fix eyes tests not being full page [test eyes]
snickell Aug 26, 2024
0fb6208
full_page_test.rb: update to latest
snickell Aug 26, 2024
ca18d24
[test eyes] now that baselines are updated
snickell Aug 26, 2024
c646f5c
[test eyes][test firefox]
snickell Aug 26, 2024
be7ceeb
Merge branch 'revert-60617-revert-60546-seth/ruby-3.3-hold-the-ruby' …
snickell Aug 26, 2024
b02e1b9
[test eyes][test firefox]
snickell Aug 26, 2024
8c68cc0
Revert "Revert "Ruby 3.3.4: pre-upgrade everything that can apply to …
snickell Sep 1, 2024
58e2e6e
[test eyes][test firefox]
snickell Sep 1, 2024
ab1f114
Gemfile.lock: use new aws-sdk-core and aws-partitions
snickell Sep 1, 2024
35fc8a7
downgrade eyes_selenium => 3.18.4
snickell Sep 10, 2024
51d8355
Merge branch 'staging' into seth/ruby-3.3-hold-the-ruby-attempt-3
snickell Sep 10, 2024
97ccd8c
Merge branch 'seth/ruby-3.3-hold-the-ruby-attempt-3' into seth/ruby-3.3
snickell Sep 10, 2024
b01fb79
Merge branch 'staging' into seth/ruby-3.3
snickell Oct 3, 2024
fc3f158
Merge branch 'staging' into seth/ruby-3.3
snickell Oct 3, 2024
de5b4ea
Merge branch 'seth/ruby-3.3' of github.com:code-dot-org/code-dot-org …
snickell Oct 3, 2024
7184070
Revert eyes_selenium 6.3.7 upgrade
snickell Oct 3, 2024
64ab568
.drone.yml: correct merge error
snickell Oct 3, 2024
a21cffe
Merge branch 'staging' into seth/ruby-3.3
snickell Oct 4, 2024
db5e222
Merge branch 'staging' into seth/ruby-3.3
snickell Oct 14, 2024
3049762
chmod +x entrypoint.sh
snickell Oct 14, 2024
8903d72
restore perms on entrypoint.sh
snickell Oct 14, 2024
3dc61e5
rerun drone after rebuilding dockerfile
snickell Oct 14, 2024
322659b
entrypoint.sh: chmod +x, see https://github.com/code-dot-org/code-dot…
snickell Oct 14, 2024
6e1d3c9
Use image name: codedotorg/code-dot-org:1.11.0
snickell Oct 14, 2024
d2bae4c
Monkeypatch `state_machine` Gem
Hamms Oct 14, 2024
f186a73
Merge branch 'staging' into seth/ruby-3.3
snickell Jan 8, 2025
3e20a1a
Back out selenium upgrade (see https://github.com/code-dot-org/code-d…
snickell Jan 8, 2025
333dc82
match staging except for Ruby upgrade itself
snickell Jan 8, 2025
6ea1191
docker/README.md: make architecture explicit (so it works on non-x86 …
snickell Jan 8, 2025
dfe5457
codedotorg/code-dot-org:1.12.0
snickell Jan 8, 2025
7182e62
Always use bundler version from ruby-build
snickell Jan 8, 2025
cdba549
cookbooks/cdo-ruby: remove bundler_version attr
snickell Jan 8, 2025
0885a3f
Only monkeypatch the state_machine gem when it is present (= in dev a…
snickell Jan 8, 2025
30f1e31
Merge branch 'staging' into seth/ruby-3.3
snickell Jan 9, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ steps:
- name: unit-tests
# see: docker/ci/Dockerfile
# TODO: switch to codedotorg/cdo-ci
image: codedotorg/code-dot-org:1.11.1
image: codedotorg/code-dot-org:1.12.0
pull: always
volumes:
- name: rbenv
Expand Down Expand Up @@ -215,7 +215,7 @@ steps:
- name: ui-tests
# see: docker/ci/Dockerfile
# TODO: switch to codedotorg/cdo-ci
image: codedotorg/code-dot-org:1.11.1
image: codedotorg/code-dot-org:1.12.0
pull: always
volumes:
- name: rbenv
Expand Down Expand Up @@ -316,6 +316,6 @@ trigger:
- push
---
kind: signature
hmac: 38a0cef75d2449a37668b441e20c4d71ab55a1809191b792fc7b2e6297f57ddb
hmac: 063d3b4aaab5a570c1034ac66e8b896a0366e39854d6b117a0faae520251e74d

...
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.5
3.3.4
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source 'https://rubygems.org'

ruby '3.0.5'
ruby '3.3.4'

# Ruby 2.7 no longer includes some libraries by default; install
# the ones we need here
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1135,7 +1135,7 @@ DEPENDENCIES
youtube-dl.rb

RUBY VERSION
ruby 3.0.5p211
ruby 3.3.4p94

BUNDLED WITH
2.3.22
2.5.17
2 changes: 1 addition & 1 deletion bin/test/i18n/test_i18n_script_utils.rb
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
let(:to_crowdin_yaml) {described_class.to_crowdin_yaml(to_crowdin_yaml_data)}

let(:to_crowdin_yaml_data) {{en: {'test' => '#example', 'yes' => 'y'}}}
let(:to_crowdin_yaml_output) {"---\n:en:\n test: \"#example\"\n 'yes': 'y'\n"}
let(:to_crowdin_yaml_output) {"---\n:en:\n test: \"#example\"\n 'yes': \"y\"\n"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Psych 4 is the YAML parser in Ruby 3.1 and has significantly different behavior (a looooot of the breakage was due to Psych 4), in this case, it returns double quotes rather than single quotes. Change cleared with Artem here: #60329 (comment)

Copy link
Contributor Author

@snickell snickell Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change to test output is triggered by the Ruby upgrade, so it needs to stay in this branch and can't be split into the pre-upgrade PR


it 'returns correctly formatted yaml' do
_(to_crowdin_yaml).must_equal to_crowdin_yaml_output
Expand Down
2 changes: 1 addition & 1 deletion cookbooks/.ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.5
3.3.4
2 changes: 1 addition & 1 deletion cookbooks/Gemfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
source 'https://rubygems.org'

ruby '3.0.5'
ruby '3.3.4'

gem 'berkshelf'
gem 'chef', '17.6.18'
Expand Down
4 changes: 2 additions & 2 deletions cookbooks/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ DEPENDENCIES
test-kitchen

RUBY VERSION
ruby 3.0.5p211
ruby 3.3.4p94

BUNDLED WITH
2.3.22
2.5.17
1 change: 0 additions & 1 deletion cookbooks/cdo-ruby/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ This cookbook uses [`ruby-build`](https://github.com/rbenv/ruby-build#readme) in

- `node['cdo-ruby']['version']`: Ruby version. See `ruby-build --definitions` for available options
- `node['cdo-ruby']['rubygems_version']`: Updates the version of [RubyGems](https://rubygems.org/) installed.
- `node['cdo-ruby']['bundler_version']`: Updates the version of [Bundler](http://bundler.io/) installed.
- `node['cdo-ruby']['rake_version']`: Updates the version of [Rake](https://ruby.github.io/rake/) installed.
7 changes: 3 additions & 4 deletions cookbooks/cdo-ruby/attributes/default.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
default['cdo-ruby'] = {
version: '3.0.5',
rubygems_version: '3.3.22',
bundler_version: '2.3.22',
rake_version: '13.0.1'
version: '3.3.4',
rubygems_version: '3.5.17 ',
rake_version: '13.2.1'
}
5 changes: 0 additions & 5 deletions cookbooks/cdo-ruby/recipes/bundler.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,6 @@
include_recipe 'apt'
apt_package 'git'

gem_package 'bundler' do
action :upgrade
version node['cdo-ruby']['bundler_version']
end

template "#{node[:home]}/.gemrc" do
source 'gemrc.erb'
user node[:user]
Expand Down
9 changes: 5 additions & 4 deletions cookbooks/cdo-ruby/recipes/ruby-build.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@

# Arbitrarily use the latest version of ruby build at time this code was
# written; this probably doesn't matter, but we need to pick something.
RUBY_BUILD_VERSION = '20221225'.freeze
RUBY_BUILD_VERSION = '20240727'.freeze
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each ruby-build version knows how to build certain versions of Ruby. Thus, when you upgrade Ruby you gotta upgrade Ruby Build.

Copy link
Contributor Author

@snickell snickell Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I debated myself here whether to split this out into the "pre-upgrade" PR. I think its actually safer to consider the ruby-build version upgrade to be part of the Ruby upgrade, and not something to do in advance. My reasoning is that in theory ruby-build being upgraded might change the Ruby 3.0.5 that was being built, and in a sense trigger exactly the scenario we were trying to avoid (having a ruby version upgrade at the same time as the mass pre-upgrade).

This way we go from Ruby 3.0.5 built with ruby-build 20221225 straight to Ruby 3.3.4 built with ruby-build 20240727. The other path passes additionally through a middle step: Ruby 3.0.5 built with ruby-build 20221225, which probably is the same as the earlier, but in the sense that the ruby binary will be replaced twice, is actually changing ruby twice, and thus I think actually increases risk rather than lowering it.


remote_file '/tmp/ruby-build.tar.gz' do
remote_file "/tmp/ruby-build-#{RUBY_BUILD_VERSION}.tar.gz" do
source "https://github.com/rbenv/ruby-build/archive/refs/tags/v#{RUBY_BUILD_VERSION}.tar.gz"
action :create_if_missing
end

archive_file '/tmp/ruby-build.tar.gz' do
archive_file "/tmp/ruby-build-#{RUBY_BUILD_VERSION}.tar.gz" do
destination '/tmp/ruby-build'
overwrite :auto
end
Expand All @@ -25,7 +25,8 @@
end

# Install dependencies require for ruby-build to succeed
apt_package %w(zlib1g-dev)
# List taken from: https://github.com/rbenv/ruby-build/wiki#ubuntudebianmint
apt_package %w(autoconf patch build-essential rustc libssl-dev libyaml-dev libreadline6-dev zlib1g-dev libgmp-dev libncurses5-dev libffi-dev libgdbm6 libgdbm-dev libdb-dev uuid-dev)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required to build new version of ruby-build.


execute 'install ruby with ruby build' do
# Target /usr/local; it might make sense to install ruby itself to /usr as
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
require_relative '../../../shared/helper_spec'

file_exist '/usr/local/bin/ruby'
cmd 'ruby -v', '3.0.5'
cmd 'gem -v', '3.3.22'
cmd 'bundler -v', '2.3.22'
cmd 'ruby -v', '3.3.4'
cmd 'gem -v', '3.5.17'
cmd 'bundler -v', '2.5.17'
5 changes: 5 additions & 0 deletions dashboard/config/application.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@
# can be automatically loaded just below.
require 'cdo/pycall'

# Monkey patch the `state_machine` gem (a dependency of `eyes_selenium`) to
# support Ruby >= 3.2. This gem was replaced with `state_machines` in
# `eyes_selenium` v6.0.4, so the patch can be removed once we upgrade.
require_relative 'monkeypatch_state_machine'

# Require the gems listed in Gemfile, including any gems
# you've limited to :test, :development, or :production.
Bundler.require(:default, Rails.env)
Expand Down
25 changes: 25 additions & 0 deletions dashboard/config/monkeypatch_state_machine.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Monkey patch the `state_machine` gem (a dependency of `eyes_selenium`) to
# support Ruby >= 3.2. This gem was replaced with `state_machines` in
# `eyes_selenium` v6.0.4, so the patch can be removed once we upgrade.
begin
require 'state_machine/integrations/base'

module StateMachine
module Integrations
module Base
module ClassMethods
# Patch the original `locale_path` method; replace deprecated
# `File.exists?` with modern `File.exist?`
#
# See https://github.com/pluginaweek/state_machine/blob/v1.2.0/lib/state_machine/integrations/base.rb#L78C24-L82C12
def locale_path
path = "#{File.dirname(__FILE__)}/#{integration_name}/locale.rb"
path if File.exist?(path)
end
end
end
end
end
rescue LoadError
# state_machine gem is only installed in test and development environments
end
2 changes: 1 addition & 1 deletion docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ docker login -u codedotorg
Build a full image to your local machine

```
docker build .
docker build --platform=linux/amd64 .
```

**Note:** We are moving to a new naming convention in order to use different docker images for different purposes. What was the `code-dot-org` image will become the `cdo-ci` image. For now, these docs advise publishing both names.
Expand Down
8 changes: 2 additions & 6 deletions docker/ci/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,8 @@ USER ${USER}

RUN mkdir -p "$(rbenv root)"/plugins && \
git clone https://github.com/rbenv/ruby-build.git "$(rbenv root)"/plugins/ruby-build && \
rbenv install 3.0.5 && \
eval "$(rbenv init -)" && \
rbenv shell 3.0.5 && \
rbenv rehash && \
gem install bundler -v 2.3.22

rbenv install 3.3.4 && \
eval "$(rbenv init -)"

#########################################################
FROM base as primary-layer
Expand Down
2 changes: 1 addition & 1 deletion docker/setup-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ version: "3"
services:
site:
# TODO: switch to codedotorg/cdo-ci or other new image
image: codedotorg/code-dot-org:1.11.1
image: codedotorg/code-dot-org:1.12.0
user: ${FIXUID:-1000}:${FIXGID:-1000}
volumes:
- ../:/home/ci/code-dot-org:delegated
Expand Down
2 changes: 1 addition & 1 deletion docker/site-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ version: "3"
services:
site:
# TODO: switch to codedotorg/cdo-ci or other new image
image: codedotorg/code-dot-org:1.11.1
image: codedotorg/code-dot-org:1.12.0
user: ${FIXUID:-1000}:${FIXGID:-1000}
volumes:
- ../:/home/ci/code-dot-org:delegated
Expand Down
2 changes: 1 addition & 1 deletion docker/ui-tests-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ version: "3"
services:
site:
# TODO: switch to codedotorg/cdo-ci or other new image
image: codedotorg/code-dot-org:1.11.1
image: codedotorg/code-dot-org:1.12.0
user: ${FIXUID:-1000}:${FIXGID:-1000}
volumes:
- ../:/home/ci/code-dot-org:delegated
Expand Down
2 changes: 1 addition & 1 deletion docker/unit-tests-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ version: "3"
services:
site:
# TODO: switch to codedotorg/cdo-ci or other new image
image: codedotorg/code-dot-org:1.11.1
image: codedotorg/code-dot-org:1.12.0
user: ${FIXUID:-1000}:${FIXGID:-1000}
volumes:
- ../:/home/ci/code-dot-org:delegated
Expand Down
Loading