seth/pretty-in-py: Python.run API - #60300
Draft
snickell wants to merge 10 commits into
Draft
Conversation
snickell
commented
Aug 10, 2024
| @@ -0,0 +1,71 @@ | |||
| require 'pty' | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
This file is just a rename of /lib/cdo/python_venv.rb, but the indentation change to make it Python::Venv instead of PythonVenv caused git to think its a new file.
snickell
commented
Aug 10, 2024
| @@ -0,0 +1,84 @@ | |||
| require 'test_helper' | |||
| require 'python/python' | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
This file is mostly a rename of pycall_test.rb with the addition of putting python calls inside a Python.run() block, which made git think it was a new file not a rename.
snickell
commented
Aug 10, 2024
| end | ||
| assert_equal 'Ruby can call Python!', result | ||
| end | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The three following tests concerning Python::ThreadSafetyError are new:
This was referenced Aug 11, 2024
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to the big PyCall PR, this creates a longer term Python API atop the PyCall library.
This is in turn extended by this PR which backs the hollow Python.run API with the real deal, PyCallThread: #60334