ci.rake: pdm install before rake lint is run - #60297
Open
snickell wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This shows where it will go in the build process for staging: |
Contributor
Author
|
@code-dot-org/infrastructure bump for review, this is a one-line change and will be necessary to have again if/when we rebuild staging from scratch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing the chef rollout for the PyCall PR #60048, we discovered that staging calls
rake lintfromrake cifromaws/ci_build. Its called beforerake installis run, which means that the Python linterpdm run ruff checkhas not been installed, and thus the build fails (build log).This PR:
pdm installfromrake ci:buildjust after runningrake ci:chef_updateand just prior to runningrake lint.I did not make it conditional on
CDO.lint, because it felt better to have the install done at a relatively predictable/stable point as this step can involved installing a new python interpreter when version change, etc.