Removed unused web-streams-polyfill package - #56803
Merged
Merged
Conversation
snickell
approved these changes
Feb 25, 2024
snickell
left a comment
snickell
left a comment
Contributor
There was a problem hiding this comment.
I did a double check and agree that we don't seem to be using this pollyfill. This package weighs in at an astonishing 10MB, so pretty glad we /didn't/ use this pollyfill ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearing out some unused packages from our package.json.
From what I can tell, the web-streams-polyfill package was a candidate for polyfilling some lost functionality when we upgraded from Webpack 4 to Webpack 5. However, I think we got that functionality via stream-browserify instead. Maddie left some great notes when she did this work: #48105. @snickell and @bencodeorg, I could definitely use a hand checking my assumptions on this one if you get the chance.
This was found using depcheck