Skip to content

Fix for ethnicity form submission#56729

Merged
juanmanzojr merged 3 commits intostagingfrom
ethnicity-response-drop-off-investigation
Feb 26, 2024
Merged

Fix for ethnicity form submission#56729
juanmanzojr merged 3 commits intostagingfrom
ethnicity-response-drop-off-investigation

Conversation

@juanmanzojr
Copy link
Contributor

@juanmanzojr juanmanzojr commented Feb 22, 2024

The ethnicity response drop off investigation led to the following conclusions:

  1. The form would not close when submitted, prompting students to click the 'Cancel' button which records a 'closed_dialog' or students would refresh the page which records 'null'.
  2. When this pop-up was overlayed another pop-up with a form, the javascript for the form would not work because the same id is being used to identify both forms.

To fix Issue 1, there was a parser error on the response of the AJAX request. Since we don't make use of the response data itself, removing the dataType field, which expected json, resulted in a successful submission.
To fix issue 2, renaming the form id for the race form allowed for submission.

Issue 1 Fix

Screen.Recording.2024-02-22.at.9.33.53.AM.mov
Screenshot 2024-02-22 at 11 14 03 AM

Issue 2: Submit button not enabled when selecting an ethnicity and there are forms overlayed:

Screenshot 2024-02-22 at 9 25 43 AM

Issue 2: After changing the form id

Screenshot 2024-02-22 at 9 28 08 AM

Links

Testing story

Local

Follow-up work

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@juanmanzojr juanmanzojr requested a review from a team February 22, 2024 17:34
@juanmanzojr juanmanzojr marked this pull request as ready for review February 22, 2024 17:59
@juanmanzojr juanmanzojr requested review from a team and artem-vavilov February 22, 2024 18:37
Copy link
Member

@artem-vavilov artem-vavilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! 👍

@juanmanzojr juanmanzojr merged commit 95c531f into staging Feb 26, 2024
@juanmanzojr juanmanzojr deleted the ethnicity-response-drop-off-investigation branch February 26, 2024 18:55
Copy link
Contributor

@wilkie wilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A fix with more deletions than inserts is a great one in my book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants