Fix for ethnicity form submission#56729
Merged
juanmanzojr merged 3 commits intostagingfrom Feb 26, 2024
Merged
Conversation
wilkie
reviewed
Feb 26, 2024
Contributor
wilkie
left a comment
There was a problem hiding this comment.
Looks good! A fix with more deletions than inserts is a great one in my book.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ethnicity response drop off investigation led to the following conclusions:
To fix Issue 1, there was a parser error on the response of the AJAX request. Since we don't make use of the response data itself, removing the dataType field, which expected json, resulted in a successful submission.
To fix issue 2, renaming the form id for the race form allowed for submission.
Issue 1 Fix
Screen.Recording.2024-02-22.at.9.33.53.AM.mov
Issue 2: Submit button not enabled when selecting an ethnicity and there are forms overlayed:
Issue 2: After changing the form id
Links
Testing story
Local
Follow-up work
PR Checklist: