Remove feedback survey on progress view - #53502
Merged
Merged
Conversation
hannahbergam
left a comment
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
Happy to approve quickly, just have a quick question!
| }, | ||
| unitSelection: {scriptId: scriptData.id}, | ||
| locales: {localeCode: 'en-US'}, | ||
| isRtl: false, |
Contributor
There was a problem hiding this comment.
Curious about how this comes into play? I don't see where the banner uses it
Contributor
Author
There was a problem hiding this comment.
Needed it to pass tests when I first made this change...for some reason 🤔
Contributor
There was a problem hiding this comment.
Got it- I see now how Notification.jsx uses it (just not passed as a prop). Makes sense that if it wasn't here before the banner, nothing else would need it now that the banner will be one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have enough (~197) responses on our feedback survey for the progress view, so we're taking it down. Git auto-revert of original PR (#51340) did not work, so doing the removal manually.
Testing story
Tested locally
Before
After
PR Checklist: