Revert "Revert "Update Ruby to 3.0.5"" - #52617
Merged
Merged
Conversation
This reverts commit ef6057b.
Hamms
added
the
Ruby Update
Hamms
marked this pull request as ready for review
July 6, 2023 19:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #52597, reapplying #50743.
The last attempt failed because Ruby 3.0 takes a much more aggressive stance toward preventing the user from using
Dir.chdirin a thread-unsafe way, which we have since addressed in #52619Testing Story
We successfully built and installed Ruby 3.0 on the staging and test servers in the last attempt, and all tests on the test server passed when run manually in serial rather than automatically in parallel. I also verified that with #52619 we are again successfully able to run tests automatically in parallel on Ruby 3.