PL Launch 2023 - Show homepage PL superhero banner to English only - #51862
Merged
Conversation
kelbyhawn
changed the title
kelbyhawn
changed the title
TurnerRiley
approved these changes
May 12, 2023
Contributor
|
Thank you for jumping on this so quickly Kelby! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the inconsistency of showing banners based on geolocation, and because we don't support non-English PL yet, we've decided to show the homepage PL hero banner to English only.
showInternationallykey with thelanguageskey since there's not adequate time to test them working together and we know thelanguageskey works.Related PR:
Jira ticket: ACQ-590
Screen.Recording.2023-05-12.at.10.17.53.AM.mov