Remove gctools Gem - #51590
Merged
Merged
Conversation
In advance of an update to Ruby 3.0
Hamms
added
the
Ruby Update
Hamms
marked this pull request as ready for review
May 19, 2023 17:57
pablo-code-org
approved these changes
May 22, 2023
cat5inthecradle
approved these changes
May 22, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In advance of an update to Ruby 3.0; this gem is not compatible with that version of Ruby, and in fact is no longer being maintained. In addition to that, disabling our use of the gem via DCDO flag does not appear to have any impact on our memory usage now that we're running Ruby 2.7, and there's even some evidence to suggest it might actually improve performance.
Links
See threads at https://codedotorg.slack.com/archives/C03CK49G9/p1684263819084909 and https://codedotorg.slack.com/archives/C03CK49G9/p1683832254038709 for more context.
See test server memory usage here
Testing story
Set the DCDO
oobgc_middleware_disabledflag totrueon both test (via DynanoDB web ui) and production-console (via console). The test server's memory usage is quite noisy, but there were no obvious increases in subsequent builds. For production-console, I manually increased our auto-scaling group's target numbers to trigger a new server to be provisioned, and verified that its memory usage stabilized at the same level as the other servers which were still running the garbage collector. I then left the flag enabled and verified that when we scaled up with the next day's traffic, the newly-provisioned servers with the garbage collector disabled continued to perform under load the same as (or better than!) those servers that were still running the garbage collector.Follow-up Work
Remove the
oobgc_middleware_disabledflag from test and prod now that we're no longer using it.