[Teach-428] Update styles on Diversity Survey - #51576
Merged
Merged
Conversation
| #submit | ||
| %button.btn-primary#submitSurvey{type: "submit"} Submit | ||
| %span#noanswer{onclick: "return submitSurvey(false)"} Prefer not to answer | ||
| %button#noanswer{onclick: "return submitSurvey(false)"} Prefer not to answer |
Contributor
There was a problem hiding this comment.
Thank you for updating this!
| @@ -3507,6 +3507,18 @@ code { | |||
|
|
|||
| #noanswer { | |||
Contributor
There was a problem hiding this comment.
Do you know if there are other elements with ids noanswer and survey. Unfortunately, they're pretty generic ids...
Contributor
Author
There was a problem hiding this comment.
Nice catch, thanks!
Agree, those are not very specific IDs.
Luckally, we only have them for this specific survey.
#noanswerstyles are set specifically to be aplied if#noansweris a child of#diversity_survey. So until we add another#diversity_surveyfor some reason 😄, everything will be fine.
Contributor
There was a problem hiding this comment.
Thanks for checking and all the screenshots!
bethanyaconnor
approved these changes
Apr 27, 2023
bethanyaconnor
left a comment
bethanyaconnor
left a comment
Contributor
There was a problem hiding this comment.
Thanks! One question to double check for any unintended consequences but otherwise looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Teach-428] Update styles on Diversity Survey
Before:
After:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: