[CFU] Add eyes tests for summary view, second try - #51517
Merged
Conversation
hannahbergam
left a comment
hannahbergam
left a comment
Contributor
There was a problem hiding this comment.
Okay flipping back and forth between this and the first attempt- this is mostly just making sure those music levels stay in allthethings, yes?
Contributor
Author
|
Yeah, the only difference should be in the
|
Contributor
Author
|
ci took way too long, so i'll merge this tomorrow. |
| @eyes | ||
| Feature: Level summary | ||
|
|
||
| Scenario: Free Response level 1 |
Contributor
There was a problem hiding this comment.
nit: can you add a comment to each of these about what these levels are specifically testing? definitely can be done as a follow up so you don't have to run this through Drone again 😅
Contributor
Author
There was a problem hiding this comment.
fair. i'll do a followup if this passes eyes
bethanyaconnor
approved these changes
Apr 26, 2023
This was referenced Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second try for #51414, reverted in #51470.
Add some feature tests for the summary view on a few Free Response levels, so we can collect visual baselines in advance of refactoring.
Since I just want the visual diffs, I didn't have any specific test cases in mind; open to feedback on whether I should add some
verifysteps or something to these.Ran locally:
