DTT (Staging > Test) [robo-dtt] - #51482
Merged
Merged
Conversation
) * Rename queue_email to send_pd_application_email * Remove deliver_now parameter * Update tests * Remove send_all_queued_emails * Update comments from queue to send * Adjust course to be consistent with hash * Stub out deliver_email * Remove deliver_now param in change principal approval * Fix variable name * Send decision emails in controller * Require status change to send email * Fix tests * Remove clearing queue from cron job * Update tests * Only log status change if status is present in params * Use post method to update applications in tests * Remove param in complete_application_reminder * Remove saving after sending * Assert response first * Stub on each test to allow expect assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.