Skip to content

use mocha rather than minitest stubs, since the latter don't work wit… - #51472

Closed
Hamms wants to merge 1 commit into
stagingfrom
test-cdo-config-changes
Closed

use mocha rather than minitest stubs, since the latter don't work wit…#51472
Hamms wants to merge 1 commit into
stagingfrom
test-cdo-config-changes

Conversation

@Hamms

@Hamms Hamms commented Apr 21, 2023

Copy link
Copy Markdown
Contributor

…h the ruby 3.x version of openstruct

Warning!!

The AP CSP Create Performance Task is in progress from April 1 - May 1 2023. Please
consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org
students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game
Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking
anything in these two labs. Even small changes, such as a different button color, are considered
significant during this time period. Reach out to the Student Learning team or Curriculum team for
more details.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms

Hamms commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

closing in favor of #51493

@Hamms Hamms closed this May 8, 2023
@Hamms
Hamms deleted the test-cdo-config-changes branch May 8, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant